boards: make: quiet sha256sum from cargo #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brghena
approved these changes
Jun 29, 2020
gendx
reviewed
Jul 16, 2020
| @@ -164,7 +164,7 @@ endif | |||
| # present, if not use the custom shipped one | |||
| ifeq (, $(shell sha256sum --version 2>/dev/null)) | |||
| # No system sha256sum available | |||
| SHA256SUM := $(CARGO) run --manifest-path $(TOCK_ROOT_DIRECTORY)tools/sha256sum/Cargo.toml -- | |||
| SHA256SUM := $(CARGO) run --manifest-path $(TOCK_ROOT_DIRECTORY)tools/sha256sum/Cargo.toml -- 2>/dev/null | |||
There was a problem hiding this comment.
I only see this now, but throwing away all of the stderr output is overkill, and makes it harder to debug legitimate errors (i.e. failing to compile the sha256sum tool). Cargo supports a --quiet flag precisely for this use case (not printing the build steps, but still printing errors).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Return the sha256sum output to how it was without all of the cargo extra text.
Without this PR:
make Compiling kernel v0.1.0 (/Users/bradjc/git/tock/kernel) Compiling cortexm v0.1.0 (/Users/bradjc/git/tock/arch/cortex-m) Compiling capsules v0.1.0 (/Users/bradjc/git/tock/capsules) Compiling cortexm4 v0.1.0 (/Users/bradjc/git/tock/arch/cortex-m4) Compiling sam4l v0.1.0 (/Users/bradjc/git/tock/chips/sam4l) Compiling components v0.1.0 (/Users/bradjc/git/tock/boards/components) Compiling hail v0.1.0 (/Users/bradjc/git/tock/boards/hail) Finished release [optimized + debuginfo] target(s) in 22.37s text data bss dec hex filename 103936 3196 13184 120316 1d5fc /Users/bradjc/git/tock/target/thumbv7em-none-eabi/release/hail Finished dev [unoptimized + debuginfo] target(s) in 0.02s Running `/Users/bradjc/git/tock/tools/sha256sum/target/debug/sha256sum /Users/bradjc/git/tock/target/thumbv7em-none-eabi/release/hail.bin` 83e84b8c50cbd7e97cef162133ad149c62d05fb7ac294df20914cba28fbaa834 /Users/bradjc/git/tock/target/thumbv7em-none-eabi/release/hail.binWith this PR:
make Compiling hail v0.1.0 (/Users/bradjc/git/tock/boards/hail) Finished release [optimized + debuginfo] target(s) in 8.05s text data bss dec hex filename 103936 3196 13184 120316 1d5fc /Users/bradjc/git/tock/target/thumbv7em-none-eabi/release/hail 83e84b8c50cbd7e97cef162133ad149c62d05fb7ac294df20914cba28fbaa834 /Users/bradjc/git/tock/target/thumbv7em-none-eabi/release/hail.binAlso add the command to the V=1 printout.
Testing Strategy
Compiling the hail kernel.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.