Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: make: quiet sha256sum from cargo #1991

Merged
merged 1 commit into from
Jun 30, 2020
Merged

boards: make: quiet sha256sum from cargo #1991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion boards/Makefile.common
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ endif
# present, if not use the custom shipped one
ifeq (, $(shell sha256sum --version 2>/dev/null))
# No system sha256sum available
SHA256SUM := $(CARGO) run --manifest-path $(TOCK_ROOT_DIRECTORY)tools/sha256sum/Cargo.toml --
SHA256SUM := $(CARGO) run --manifest-path $(TOCK_ROOT_DIRECTORY)tools/sha256sum/Cargo.toml -- 2>/dev/null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see this now, but throwing away all of the stderr output is overkill, and makes it harder to debug legitimate errors (i.e. failing to compile the sha256sum tool). Cargo supports a --quiet flag precisely for this use case (not printing the build steps, but still printing errors).

else
# Use system sha256sum
SHA256SUM := sha256sum
Expand Down Expand Up @@ -198,6 +198,7 @@ ifneq ($(V),)
$(info OBJDUMP = $(OBJDUMP))
$(info CARGO = $(CARGO))
$(info RUSTUP = $(RUSTUP))
$(info SHA256SUM = $(SHA256SUM))
$(info )
$(info cargo --version = $(shell $(CARGO) --version))
$(info rustc --version = $(shell rustc --version))
Expand Down