Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ADC support for stm323f303xc #2000

Merged
merged 21 commits into from Jul 17, 2020

Conversation

cosmindanielradu19
Copy link
Contributor

@cosmindanielradu19 cosmindanielradu19 commented Jul 4, 2020

Pull Request Overview

This pull request adds single sample ADC support for stm323f303xc

Testing Strategy

This pull request was tested by using a stm323f3discovery kit

TODO or Help Wanted

Continuous mode implementation troubles. The speed of interrupts is too high and can't send response with Data to the client.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! We have been wanting more widespread ADC support in Tock for awhile, so this is exciting to see. I really appreciate all the well commented code.

I have a few comments below

boards/stm32f3discovery/src/main.rs Outdated Show resolved Hide resolved
boards/stm32f3discovery/Makefile Outdated Show resolved Hide resolved
boards/stm32f3discovery/Makefile Outdated Show resolved Hide resolved
boards/stm32f3discovery/src/main.rs Show resolved Hide resolved
boards/stm32f3discovery/src/main.rs Outdated Show resolved Hide resolved
chips/stm32f303xc/src/adc.rs Outdated Show resolved Hide resolved
chips/stm32f303xc/src/adc.rs Outdated Show resolved Hide resolved
chips/stm32f303xc/src/adc.rs Show resolved Hide resolved
chips/stm32f303xc/src/adc.rs Outdated Show resolved Hide resolved
chips/stm32f303xc/src/adc.rs Show resolved Hide resolved
boards/stm32f3discovery/src/main.rs Outdated Show resolved Hide resolved
chips/stm32f303xc/src/adc.rs Show resolved Hide resolved
chips/stm32f303xc/src/adc.rs Show resolved Hide resolved
boards/stm32f3discovery/src/main.rs Outdated Show resolved Hide resolved
chips/stm32f303xc/src/adc.rs Show resolved Hide resolved
@brghena brghena mentioned this pull request Jul 7, 2020
2 tasks
Copy link
Contributor

@bradjc bradjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going with @brghena's recommendation that the capsule should be split, and this is good right now.

chips/stm32f303xc/src/rcc.rs Outdated Show resolved Hide resolved
chips/stm32f303xc/src/adc.rs Outdated Show resolved Hide resolved
chips/stm32f303xc/src/adc.rs Outdated Show resolved Hide resolved
bradjc
bradjc previously approved these changes Jul 16, 2020
@bradjc bradjc added the last-call Final review period for a pull request. label Jul 16, 2020
@bradjc
Copy link
Contributor

bradjc commented Jul 17, 2020

@hudson-ayers

@bradjc
Copy link
Contributor

bradjc commented Jul 17, 2020

bors r+

@bors bors bot merged commit 8a6f788 into tock:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
last-call Final review period for a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants