New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ADC support for stm323f303xc #2000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! We have been wanting more widespread ADC support in Tock for awhile, so this is exciting to see. I really appreciate all the well commented code.
I have a few comments below
used channels 1..5 because those are fast ADC channels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going with @brghena's recommendation that the capsule should be split, and this is good right now.
bors r+ |
Pull Request Overview
This pull request adds single sample ADC support for stm323f303xc
Testing Strategy
This pull request was tested by using a stm323f3discovery kit
TODO or Help Wanted
Continuous mode implementation troubles. The speed of interrupts is too high and can't send response with Data to the client.
Documentation Updated
/docs
, or no updates are required.Formatting
make prepush
.