Adding ADC support for stm323f4xx #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for all the STM32 ADC work! I think whatever issues and decisions come up in #2000 apply equally here as well. And once #2000 is merged, this should be pretty straightforward to pull. Are there any major differences between the ADC implementation for the F3 and F4 that we should be on the lookout for? |
|
There are some differences, there are different registers, the powering on sequence is different and the way that samples are requested differ. |
bradjc
approved these changes
Jul 16, 2020
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds single sample ADC support for stm323f4xx.
Testing Strategy
This pull request was tested by using a stm323f412g discovery
TODO or Help Wanted
Continuous mode implementation troubles. The speed of interrupts is too high and can't send response with Data to the client.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.