Makefile: Don't run the setup commands inside bash #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrvanwhy
previously approved these changes
Jul 14, 2020
hudson-ayers
previously approved these changes
Jul 15, 2020
ppannuto
reviewed
Jul 15, 2020
Instead of running the setup commands as part of bash -c * just have Make call them from the shell. This fixes a build failure seen at: tock/libtock-rs#210 Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
alistair23
force-pushed
the
alistair/Makefile-no-bash
branch
from
b87791d
to
47da0c1
Compare
hudson-ayers
approved these changes
Jul 16, 2020
jrvanwhy
approved these changes
Jul 17, 2020
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
jrvanwhy
added a commit
to jrvanwhy/libtock-rs
that referenced
this pull request
Aug 3, 2020
1. Update the `tock` submodule to a version that includes tock/tock#2024, which fixes the OpenTitan BootROM download code, as well as tock/tock#2038, which fixes a HiFive1 kernel bug. 2. Update the setup-qemu make target to track changes in Tock's makefile. 3. Point `test_runner` to the new QEMU location. 4. Disable the callback test. HiFive1 doesn't have a working timer driver. The callback test only worked before because of some other callback, which doesn't seem to occur with the new kernel.
jrvanwhy
added a commit
to jrvanwhy/libtock-rs
that referenced
this pull request
Aug 3, 2020
1. Update the `tock` submodule to a version that includes tock/tock#2024, which fixes the OpenTitan BootROM download code, as well as tock/tock#2038, which fixes a HiFive1 kernel bug. 2. Update the setup-qemu make target to track changes in Tock's makefile. 3. Point `test_runner` to the new QEMU location. 4. Disable the callback test. HiFive1 doesn't have a working timer driver. The callback test only worked before because of some other callback, which doesn't seem to occur with the new kernel.
bors bot
added a commit
to tock/libtock-rs
that referenced
this pull request
Aug 4, 2020
226: Fix the broken Travis CI: r=jrvanwhy a=jrvanwhy 1. Update the `tock` submodule to a version that includes tock/tock#2024, which fixes the OpenTitan BootROM download code, as well as tock/tock#2038, which fixes a HiFive1 kernel bug. 2. Disable the callback test. HiFive1 doesn't have a working timer driver. The callback test only worked before because of some other callback, which doesn't seem to occur with the new kernel. Fixes #225 Co-authored-by: Johnathan Van Why <jrvanwhy@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Instead of running the setup commands as part of bash -c * just have
Make call them from the shell.
This fixes a build failure seen at: tock/libtock-rs#210
Testing Strategy
Running the CI
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.