Update tock-registers doc to fix mistake #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default is u32, and register fields in the example were greater than 8 bits in size, so we should just use 32-bits as the register size in the example.
|
@alistair23 any ideas why the QEMU check is failing? |
hudson-ayers
approved these changes
Aug 13, 2020
|
The CI should be fixed now. |
bradjc
approved these changes
Aug 14, 2020
ppannuto
added a commit
that referenced
this pull request
Nov 11, 2020
Changes since v0.5: - #2095: Fix syntax errors and inconsistencies in documentation - #2071: Clarify bit widths in documentation examples - #2015: Use UnsafeCell in registers (see issue #2005) - #1939: Make the Field::mask and FieldValue::mask fields private - #1823: Allow large unsigned values as bitmasks + add bitmask! helper macro - #1554: Allow lifetime parameters for `register_structs! { Foo<'a> { ..` - #1661: Add `Aliased` register type for MMIO with differing R/W behavior Thanks to @namyoonw, @brghena, @dabross, @gendx, @hudson-ayers, and @pfmooney for contributions, fixes, and testing! Closes #2138.
hudson-ayers
pushed a commit
that referenced
this pull request
Mar 7, 2022
Changes since v0.5: - #2095: Fix syntax errors and inconsistencies in documentation - #2071: Clarify bit widths in documentation examples - #2015: Use UnsafeCell in registers (see issue #2005) - #1939: Make the Field::mask and FieldValue::mask fields private - #1823: Allow large unsigned values as bitmasks + add bitmask! helper macro - #1554: Allow lifetime parameters for `register_structs! { Foo<'a> { ..` - #1661: Add `Aliased` register type for MMIO with differing R/W behavior Thanks to @namyoonw, @brghena, @dabross, @gendx, @hudson-ayers, and @pfmooney for contributions, fixes, and testing! Closes #2138. BUG=none TEST=make (cherry picked from commit 72a1e1e) Change-Id: Ia2dbf69c950e3581a43f5d6601a5cf94abace750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default is u32, and register fields in the example were greater than 8 bits in size, so we should just use 32-bits as the register size in the example.
Pull Request Overview
Modifies tock-registers README.
Testing Strategy
N/A
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.