Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tock-registers README.md #2095

Merged
merged 1 commit into from Sep 3, 2020
Merged

Update tock-registers README.md #2095

merged 1 commit into from Sep 3, 2020

Conversation

namyoonw
Copy link
Contributor

@namyoonw namyoonw commented Sep 3, 2020

  • added missing commas in Registers group.
  • fixed the number of bits of RANGE to 2.
  • Removed the text mentioning 'CR' since it has gone.
  • registers.s is ReadOnly. Changed the example line to use ".read()" rather than ".modify()".

Pull Request Overview

This pull request adds/changes/fixes...

Testing Strategy

This pull request was tested by...

TODO or Help Wanted

This pull request still needs...

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

- added missing commas in Registers group.
- fixed the number of bits of RANGE to 2.
- Removed the text mentioning 'CR' since it has gone.
- registers.s is ReadOnly. Changed the example line to use ".read()" rather than ".modify()".
@bradjc bradjc changed the title Update README.md Update tock-registers README.md Sep 3, 2020
@brghena
Copy link
Contributor

brghena commented Sep 3, 2020

bors r+

@bors bors bot merged commit c1906ed into tock:master Sep 3, 2020
ppannuto added a commit that referenced this pull request Nov 11, 2020
Changes since v0.5:

 - #2095: Fix syntax errors and inconsistencies in documentation
 - #2071: Clarify bit widths in documentation examples
 - #2015: Use UnsafeCell in registers (see issue #2005)
 - #1939: Make the Field::mask and FieldValue::mask fields private
 - #1823: Allow large unsigned values as bitmasks + add bitmask! helper macro
 - #1554: Allow lifetime parameters for `register_structs! { Foo<'a> { ..`
 - #1661: Add `Aliased` register type for MMIO with differing R/W behavior

Thanks to @namyoonw, @brghena, @dabross, @gendx, @hudson-ayers, and @pfmooney
for contributions, fixes, and testing!

Closes #2138.
@ppannuto ppannuto mentioned this pull request Nov 11, 2020
2 tasks
hudson-ayers pushed a commit that referenced this pull request Mar 7, 2022
Changes since v0.5:

 - #2095: Fix syntax errors and inconsistencies in documentation
 - #2071: Clarify bit widths in documentation examples
 - #2015: Use UnsafeCell in registers (see issue #2005)
 - #1939: Make the Field::mask and FieldValue::mask fields private
 - #1823: Allow large unsigned values as bitmasks + add bitmask! helper macro
 - #1554: Allow lifetime parameters for `register_structs! { Foo<'a> { ..`
 - #1661: Add `Aliased` register type for MMIO with differing R/W behavior

Thanks to @namyoonw, @brghena, @dabross, @gendx, @hudson-ayers, and @pfmooney
for contributions, fixes, and testing!

Closes #2138.

BUG=none
TEST=make

(cherry picked from commit 72a1e1e)
Change-Id: Ia2dbf69c950e3581a43f5d6601a5cf94abace750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants