Add userspace support for the Key/Value System #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
HIL
bradjc
reviewed
Dec 21, 2021
| }) | ||
| } | ||
|
|
||
| fn check_queue(&self) { |
There was a problem hiding this comment.
This seems out of place here, but, I feel like you've come this far, maybe it's worth doing the userspace virtualization too?
alistair23
force-pushed
the
alistair/storage-ids-capsule
branch
2 times, most recently
from
00bb0dc
to
c421903
Compare
alistair23
force-pushed
the
alistair/storage-ids-capsule
branch
from
c421903
to
610ff10
Compare
|
Just pushed an update! |
kernel/src/process.rs
Outdated
Comment on lines
438
to
441
| /// Get the process `write_id`. | ||
| /// Returns `None` if a `write_id` is not included. | ||
| fn get_write_id(&self) -> Option<u32>; | ||
|
|
||
| /// Get the `read_ids`. | ||
| /// Returns `None` if a `read_ids` is not included. | ||
| fn get_read_ids(&self) -> Option<[u32; 8]>; | ||
|
|
||
| /// Get the number of `read_ids`. | ||
| /// Returns `None` if a `read_ids` is not included. | ||
| fn num_read_ids(&self) -> Option<usize>; | ||
|
|
||
| /// Get the `access_ids`. | ||
| /// Returns `None` if a `access_ids` is not included. | ||
| fn get_access_ids(&self) -> Option<[u32; 8]>; | ||
|
|
||
| /// Get the number of `access_ids`. | ||
| /// Returns `None` if a `access_ids` is not included. | ||
| fn num_access_ids(&self) -> Option<usize>; | ||
|
|
There was a problem hiding this comment.
All boards pay for the code size of this support, even if they do not use the KV system. Looks like it is about 250 bytes per board, which is of course not a ton. I think long-term it is important for Tock to find ways to expose TBF header extensions to capsules in a configurable manner, but won't ask to block this PR on that support
There was a problem hiding this comment.
Hopefully long term we can eliminate virtual functions with rust-lang/rust#68262
alistair23
force-pushed
the
alistair/storage-ids-capsule
branch
2 times, most recently
from
1582745
to
61caaac
Compare
hudson-ayers
previously approved these changes
Feb 1, 2022
twilfredo
previously approved these changes
Feb 4, 2022
|
I marked this last-call, but pinging in case anyone else wants to do a final review |
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
If the total length is too long for the buffer, let's at least return some of the data and an error. This is really useful when trying to check is a caller has permission to delete a key, as now we don't need a really large buffer to store the value. Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
This is the initial commit of KV Store. KV store is like a virtuliser and exposes the hil::kv_system in a user friendly way that can be used by app drivers or the kernel. Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
alistair23
dismissed stale reviews from twilfredo and hudson-ayers
via
f9892bc
alistair23
force-pushed
the
alistair/storage-ids-capsule
branch
from
61caaac
to
f9892bc
Compare
|
Just pushed an update to try and address issues raised by @bradjc in the last OT call |
bradjc
reviewed
Feb 14, 2022
|
Take a look at the commits I added. The major change is adding |
alistair23
commented
Mar 8, 2022
kernel/src/process_standard.rs
Outdated
|
|
||
| fn get_write_permissions(&self) -> WritePermissions { | ||
| let write_id = self.header.get_write_id().unwrap_or(0); | ||
| let (write_count, write_storage_ids) = self |
There was a problem hiding this comment.
access_count, access_storage_ids
alistair23
commented
Mar 8, 2022
| /// Returns `None` if `access_ids` are not included. | ||
| fn get_write_permissions(&self) -> WritePermissions; | ||
| /// Get the storage permissions for the process. | ||
| fn get_storage_permissions(&self) -> Option<storage_permissions::StoragePermissions>; |
There was a problem hiding this comment.
Returns None if the process has no storage permissions.
|
Looks good |
bradjc
approved these changes
Mar 8, 2022
|
Looks good to me |
|
bors r+ |
bors bot
added a commit
to tock/libtock-c
that referenced
this pull request
Mar 11, 2022
273: Add userspace support for the Key/Value System r=hudson-ayers a=alistair23 This uses tock/tock#2928 and access and tests Tock's KV System Co-authored-by: Alistair Francis <alistair.francis@wdc.com>
tyler-potyondy
pushed a commit
to tyler-potyondy/libtock-c
that referenced
this pull request
Mar 13, 2024
273: Add userspace support for the Key/Value System r=hudson-ayers a=alistair23 This uses tock/tock#2928 and access and tests Tock's KV System Co-authored-by: Alistair Francis <alistair.francis@wdc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This exposes Tock's Key/value system to userspace.
Testing Strategy
Running the libtock-c example app on OpenTitan.
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.