opentitan: verilator: fixup test build #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
WG-OpenTitan
alistair23
suggested changes
Feb 10, 2022
Fixup an issue when `make test-verilator` is ran, the binary loaded to verilator is incorrect. It would load the `binary.64.vmem` file which might have been previously created by `make BOARD_CONFIGURATION=sim_verilator verilator` or not at all (error). Note that a `.vmem` created by the previos command will not include any tests. This PR updates the `makefile/run.sh` for cw130/nexysvideo to ensure that the test binary is correctly loaded into verilator. Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
twilfredo
force-pushed
the
twilfred-verilator-tests-fixup
branch
from
3adbf56
to
dee4eab
Compare
alistair23
approved these changes
Feb 17, 2022
bradjc
approved these changes
Feb 18, 2022
bors bot
added a commit
that referenced
this pull request
Feb 28, 2022
2966: opentitan: add spi_host r=bradjc a=thulithwilfred ### Pull Request Overview This pull request adds spi_host implementation to opentitan. The driver has been designed with reference to [1]. Opentitan has both spi_device and spi_host capabilities, this PR implements only the spi_host. The base register mapping can be found [2]. ### Testing Strategy Tested by using Verilator and basic testing on FPGA with the provided unit tests. For Verilator testing, this PR depends on: - #2963 Tested on the ongoing `ibex_spi` development branch on qemu. ### TODO Mainline qemu still requires a patch to update spi_host/spi_device base addresses. As such, testing on qemu by including the `#cfg...` will cause a store access fault when the board initializes SPI and attempts to write to 'invalid' registers in qemu. To avoid CI failure, these sections have be isolated using `#cfg...`. To be removed when qemu fixup pr is merged. ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. ### References [1] https://docs.opentitan.org/hw/ip/spi_host/doc/ [2] https://github.com/lowRISC/opentitan/blob/6c317992fbd646818b34f2a2dbf44bc850e461e4/hw/top_earlgrey/sw/autogen/top_earlgrey_memory.h#L107 Co-authored-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Fixup an issue when
make test-verilatoris ran, the binary loaded toVerilator is incorrect. It would load the
binary.64.vmemfile whichmight have been previously created by
make BOARD_CONFIGURATION=sim_verilator verilatoror not at all (error). Note thata
.vmemcreated by the previous command will not have been built for tests.This PR updates the
makefile/run.shfor cw130/nexysvideo to ensurethat the
.vmemcreated using the test binary is loaded into Verilator.Depends
This PR builds on:
All merged.
Testing Strategy
make test-verilatorfor both boards. The test outputs observed overscreen dev/pts/x.TODO or Help Wanted
To keep things tidy, I output all the Verilator test build files into
verilator_build/within the current board directory. So you could easily just delete that after. What do you guys think about this implementation?Documentation Updated
/docs, or no updates are required.Formatting
make prepush.Update
17/2 - Implemented OBJCOPY variable to be used for object copying.