Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple boards: refactored GET_PERIPHERALS #3385

Merged
merged 1 commit into from
Feb 7, 2023
Merged

multiple boards: refactored GET_PERIPHERALS #3385

merged 1 commit into from
Feb 7, 2023

Conversation

RaresCon
Copy link
Contributor

Pull Request Overview

This pull request refactors all appearances of the get_peripherals() function to create_peripherals().
Issue: #3270

Testing Strategy

This pull request was not tested being only refactoring.

TODO or Help Wanted

This pull request still needs feedback / code review.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@RaresCon
multiple boards: refactored GET_PERIPHERALS
7b8ed2a 
Replaced all the 46 appearances of GET_PERIPHERALS function
with CREATE_PERIPHERALS as requested in Issue tock#3270
@RaresCon RaresCon mentioned this pull request Jan 27, 2023
Closed
2 tasks
twilfredo
twilfredo approved these changes Jan 29, 2023
View reviewed changes
Copy link
Contributor

@twilfredo twilfredo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looks like this closes #3270

lschuermann
lschuermann approved these changes Jan 29, 2023
View reviewed changes
Copy link
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have any strong feelings about this change, but not opposed to it.

hudson-ayers
hudson-ayers approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@hudson-ayers hudson-ayers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brad was anti-churn on this in the original issue, but I think this is worth the added clarity at the cost of 46 lines changed.

@lschuermann lschuermann added the P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. label Jan 30, 2023
@hudson-ayers
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 7, 2023

Build succeeded:

@bors bors bot merged commit 9f091be into tock:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair23 alistair23 alistair23 approved these changes

@lschuermann lschuermann lschuermann approved these changes

@hudson-ayers hudson-ayers hudson-ayers approved these changes

@twilfredo twilfredo twilfredo approved these changes

Assignees
No one assigned
Labels
P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RaresCon @hudson-ayers @alistair23 @lschuermann @twilfredo