Refactoring get_peripherals #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First drat of TRD for license and copyright rules for the Tock project.
…ignore all files without license headers.
|
This looks good, please rebase it to the newest master. @RaresCon |
alexandruradovici
added
the
needs-rebase
…ate examples, include "Copyright Tock Contributors" in the examples.
License policy 2023-01-23 core call updates
…ividual contributor copyright from the main example.
|
I'm sorry for replying so late, I had some problems regarding the way of rebasing my fork. So, in short, my repo is forked from the original Tock repo, so I can't really rebase to the newest master of this one. I tried some dark magic in the past days, but couldn't remove the commits coming from the origin. So I wanted to ask, may I reopen this PR after forking it from here with the same changes? The reason for forking the original one is that I wanted to have access to the newest tree, so I can see if some issues are still active. |
alexandruradovici
added
needs-rebase
|
Please rebase it to the Tock master and force-push it here. |
3369: debug_writer_component: make debug buffer size configurable; double default debug buffer size r=hudson-ayers a=hudson-ayers ### Pull Request Overview This pull request makes the debug buffer size configurable via an optional macro argument, and doubles the default size of the buffer to 2kB. I modified the Hifive1 to use the configurable parameter so that it still uses a 1kB buffer, since it is highly RAM constrained. This PR was inspired by tock#3327, which will ultimately require a much larger buffer (~8kB) for boards that use it. ### Testing Strategy This pull request was tested by compiling. ### TODO or Help Wanted Are any other boards sufficiently RAM constrained as to require a smaller buffer than 2kB? ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Hudson Ayers <hayers@stanford.edu>
3318: trd: license and copyright policy r=alevy a=ppannuto ### Pull Request Overview First draft of TRD for license and copyright rules for the Tock project. ### Testing Strategy N/A ### TODO or Help Wanted Review of language and policy decisions. ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [ ] Ran `make prepush`. Co-authored-by: Pat Pannuto <pat.pannuto@gmail.com> Co-authored-by: Amit Aryeh Levy <amit@amitlevy.com> Co-authored-by: Brad Campbell <bradjc5@gmail.com> Co-authored-by: Johnathan Van Why <jrvanwhy@google.com>
3345: Add a license checking tool. r=alevy a=jrvanwhy ### Pull Request Overview This pull request adds a tool that checks for license headers as specified in tock#3318. ### Testing Strategy I adapted `ci-job-tools` to run tests in the `tools/` workspace, and ran the tool by hand to verify it reports errors + success correctly. ### TODO or Help Wanted tock#3318 is undergoing revision. I currently have the license checker disabled on all files *except new files added in this PR*, because otherwise it does its job and fails CI. Also, after license headers are added, I need to evaluate the speed of the tool. It currently runs in 100 milliseconds, which seems fast enough, but it may slow down when license headers are added (it may also speed up). If it slows down too much (e.g. takes over a second), I'll revert to a simpler -- but less accurate -- parsing implementation. ### Documentation Updated - [X] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [X] Ran `make prepush`. Co-authored-by: Johnathan Van Why <jrvanwhy@google.com>
Replaced all the 46 appearances of GET_PERIPHERALS function with CREATE_PERIPHERALS as requested in Issue tock#3270
RaresCon
force-pushed
the
refactor-get_peripherals
branch
from
c58d943
to
7b8ed2a
Compare
|
Send it to upstream and post a link. |
alexandruradovici
approved these changes
Jan 27, 2023
alexandruradovici
added
the
upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request refactors all appearances of the
get_peripherals()function tocreate_peripherals().Issue: tock#3270
Testing Strategy
This pull request was not tested being only refactoring.
TODO or Help Wanted
This pull request still needs feedback / code review.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.