Move some cortex-m specific code to arch/ #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
The `ipsr_isr_number_to_str()` function maps interrupts to string names, but is architecture specific so it shouldn't be in process.rs.
kernel::support::arm has moved to arch/cortex-m because the kernel should be architecture agnostic.
alevy
previously approved these changes
May 26, 2018
ppannuto
force-pushed
the
kernel-no-swiping
branch
from
47e96c2
to
e391038
Compare
ppannuto
force-pushed
the
kernel-no-swiping
branch
from
e391038
to
de9cbcf
Compare
ppannuto
approved these changes
May 26, 2018
bradjc
added
the
P-Upkeep
9 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request moves the
ipsr_isr_number_to_str()function out of process.rs and into arch.It also moves the
kernel::support::armmodules toarch/cortex-m.Testing Strategy
This pull request was tested by
make allboards.TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make formatall.