New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nightly (June 2018) #997

Merged
merged 4 commits into from Jun 26, 2018

Conversation

Projects
None yet
4 participants
@bradjc
Copy link
Contributor

bradjc commented Jun 14, 2018

Pull Request Overview

This pull request updates rust to a recent version.

That also means a new rustfmt, which is annoying. The commits are more easily viewed independently.

Testing Strategy

This pull request was tested by running hail on hail.

TODO or Help Wanted

n/a

Documentation Updated

  • Kernel: Updated the relevant files in /docs, or no updates are required.
  • Userland: Added/updated the application README, if needed.

Formatting

  • Ran make formatall.
@phil-levis
Copy link
Collaborator

phil-levis left a comment

Should we get into the habit of bumping version after each release?

@bradjc bradjc force-pushed the nightly-update-june-2018 branch from c5fa94e to 7ffb982 Jun 21, 2018

@bradjc bradjc added the blocked label Jun 21, 2018

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jun 21, 2018

Should we get into the habit of bumping version after each release?

We pretty much are already doing that by updating the nightly every two months. And I think it makes sense to do it after a release so there is time for people to use it and test it.

This is blocked on tonight's nightly which should include binutils.

@bradjc bradjc force-pushed the nightly-update-june-2018 branch 2 times, most recently from cc80a39 to 1284b34 Jun 21, 2018

bradjc added some commits Jun 12, 2018

rustfmt: update to 0.8.2
Use the `rustfmt-preview` component so that each user doesn't have to
compile rustfmt.

@bradjc bradjc force-pushed the nightly-update-june-2018 branch from 1284b34 to 1b95288 Jun 26, 2018

@bradjc bradjc removed the blocked label Jun 26, 2018

@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jun 26, 2018

Ok! This is ready to go now.

"fix" some rustdoc warnings
We get warnings for "links" that don't work now. See if this allows
netlify to succeed.
@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jun 26, 2018

And travis only takes 5m versus 19m for current pull requests.

@niklasad1 niklasad1 referenced this pull request Jun 26, 2018

Merged

Use LLVM Tools #1031

0 of 2 tasks complete
@bradjc

This comment has been minimized.

Copy link
Contributor

bradjc commented Jun 26, 2018

Anyone not ok with merging this? I've been waiting for a nightly to land that includes llvm-tools, but otherwise this hasn't changed much from 12 days ago. Included in this PR:

  • Use nightly-2018-06-26.
  • Remove the install rustfmt script and instead use rustup component add rustfmt-preview. This solves two problems: 1) we don't have to compile rustfmt any more :))) and 2) rustfmt is tied to the version of rust so no more guessing about which rustfmt version will work with which nightly. It also has an additional benefit: travis is much faster.
  • Actually run rustfmt, which makes a ton of minor changes. I guess that is the price of progress and convenience. There is a milestone and tracking issue for rustfmt 1.0: https://github.com/rust-lang-nursery/rustfmt/milestone/2. As far as I can tell 1.0 would guarantee that any format specified in the RFC that is eventually merged wouldn't change, but that unspecified format could still change in the future. I also get the sense that deciding that that RFC is done and ready to merge is the real blocking issue.

@bradjc bradjc added the last-call label Jun 26, 2018

@bradjc bradjc merged commit f3ada29 into master Jun 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@bradjc bradjc deleted the nightly-update-june-2018 branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment