Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLs with "Content-type:application/json" cause ScriptService to fail #81

Closed
todbot opened this issue Jan 12, 2018 · 1 comment
Closed

URLs with "Content-type:application/json" cause ScriptService to fail #81

todbot opened this issue Jan 12, 2018 · 1 comment
Labels
confirmed bug

Comments

@todbot
Copy link
Owner

todbot commented Jan 12, 2018 •
edited
Loading

URLs that return content with Content-type set to "application/json" appear to return a Buffer instead of a String.

As noticed by user Bry via email.
todbot added a commit that referenced this issue Jan 12, 2018
@todbot
ScriptService: fix URL parsing issue #81
d6a28f7
@todbot
Copy link
Owner Author

todbot commented Jan 13, 2018

Fixed in 2.1.0.

@todbot todbot changed the title URLs with "Content-type:application/json" cause ScriptService to crash URLs with "Content-type:application/json" cause ScriptService to fail Jan 13, 2018
todbot added a commit that referenced this issue Jan 13, 2018
@todbot
fix ScriptService again for URL color match case, related to issue #81 …
11b289c 
…slightly
@todbot todbot closed this as completed Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@todbot