Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aria-label to main element #155

Merged
merged 1 commit into from
Nov 20, 2016

Conversation

scottaohara
Copy link
Contributor

This is a small quality of life update for screen readers, so now the

element will be announced as ‘main content’ rather than just ‘main’, adding a bit of extra context for these users.

This is a small quality of life update for screen readers, so now the <main> element will be announced as ‘main content’ rather than just ‘main’.
@oriSomething
Copy link
Collaborator

I'm really not sure about this. Did you something like this anywhere?

@toddmotto
Copy link
Member

Just had a quick google search as I've not seen it before either (weird also that it's capital C too). Found Jekyll had changed to it: https://github.com/jekyll/jekyll/pull/4636/files

@scottaohara
Copy link
Contributor Author

this is an extra label that i first learned about working w/the lead accessibility engineer at edX, and have since tested this with screen reader users that have unanimously appreciated the inclusion of it on various other projects i've worked on.

@oriSomething
Copy link
Collaborator

@scottaohara Hey, but is there any medium+ size website out there that implement this?

@scottaohara
Copy link
Contributor Author

scottaohara commented Nov 19, 2016

As i mentioned, there's https://www.edx.org. They'd definitely meet the medium+ category since their site is used the world over for higher education.

The Perkins School for the Blind also does this...and they're one of the leading international institutions for blind individuals and assistive technology training.

But to be honest with you, there are far more sites out there, especially medium-large sites, that have abysmal a11y support. So I wouldn't expect to find this used a lot in the wild, because 1. not many people are aware of how little extras like this can help screen reader users, and 2. many large, popular sites are a sea of divs... building sites w/accessibility in mind is unfortunately not yet a truly common practice...

So I'll mention again, this has been received very well in the tests i've performed with screen reader users. I've included this on at least 4 other large scale websites/apps that I am not at liberty to name due to NDAs. But I'm at a loss for how else to explain that this is a beneficial add...

@oriSomething
Copy link
Collaborator

LGTM

@oriSomething oriSomething merged commit ce78d01 into html5blank:master Nov 20, 2016
@scottaohara
Copy link
Contributor Author

thanks :)

@scottaohara scottaohara deleted the main-aria-label-update branch November 20, 2016 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants