update #1
Open
update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createTempFile creates a file, so it is not compatible with a directory migration. The first thing I tried was a migration of the examples webapp and it didn't work since this is an exploded folder.
Ensure that a response is not corrupted as well as incomplete if the connection is closed before the response is fully written due to a write timeout. https://bz.apache.org/bugzilla/show_bug.cgi?id=65137
When replacing a closed Stream with a RecycledStream instance, the priority hierarchy was not maintained. This led to NPEs during the pruning process.
Also covers setContentType(null) and setLocale(null) https://bz.apache.org/bugzilla/show_bug.cgi?id=64938
Related to bug 65131, make sure all errors from OpenSSL are fully cleared, as there could be more than one error present after an operation (confirmed in the OpenSSL API documentation).
If the non-blocking I/O error occurred in onWritePossible() or onDataAvailable() (rather than when buffered data was being written in the background) the error was not propogated to the AsyncListener.
Tomcat previously expected IOExceptions in onWritePossible() and onDataAvailable() to not be swallowed. These additions allow correct error handling even if the application code swallows the exception.
This moves us off 5.3.0-SNAPSHOT
If t == null this code has no effect If t != null it is re-added in asyncConImpl.setErrorState
This method is called for a SimpleTag. pushBodyCountVar is always null for SimpleTag as the code where it is set in visit(CustomTag) is never called if n.implementsSimpleTag() is true.
NPE in JNDIRealm, when userRoleAttribute is not set. Plus add path to UnboundID SDK to the Eclipse and Intellij classpath settings. Bugzilla Id: 63508
If a tag file uses a named attribute, the TagFileDirectiveVisitor will ensure that an alias is configured.
These tests are fairly simple in that they only check for the correct return code. The do not check the content of response body. The aim of the tests is to detect a compilation problem with the Java code generated from a JSP if the generation process is optimised (eg to remove a variable declaraton in some cases) incorrectly. Coverage is as close to 100% as practical for the Generator class
Based on a PR by Jean-Louis Monteiro Also adds support for the <pr> element in the change log
Based on a PR by Arnaud Dagnelies.
…ert header from Nginx
Based on a patch provided by Saksham Verma. https://bz.apache.org/bugzilla/show_bug.cgi?id=65317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update