Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Vale spelling checker to v3 #450

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

koozz
Copy link
Contributor

@koozz koozz commented Mar 22, 2024

Add author names to accepted list as well as company names.

This should remove the clutter from the spell checker.
There are some obvious spelling errors visible now, these can be fixed in a separate pull request.

The new Vale (i.e. for MacOS brew install vale, at the time of writing 3.3.0) will run nicely with the configuration in this repository.

> vale ospo-book/content/en

ospo-book/content/en/glossary.md
 39:63  error  Use 'InnerSource' instead of    Vale.Terms
               'innerSource'.
 72:44  error  Did you really mean             Vale.Spelling
               'interoperate'?
 80:46  error  Did you really mean 'Chai'?     Vale.Spelling

...

✖ 24 errors, 0 warnings and 0 suggestions in 15 files.

These content changes can be picked up in a new pull request, that way, the reviewers can have another look.

Add author names to accepted list as well as company names.

Signed-off-by: Jan van den Berg <koozz@linux.com>
Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for ospobook canceled.

Name Link
🔨 Latest commit f24341c
🔍 Latest deploy log https://app.netlify.com/sites/ospobook/deploys/65fd9e030300ae000846df30

Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for ospomindmap canceled.

Name Link
🔨 Latest commit f24341c
🔍 Latest deploy log https://app.netlify.com/sites/ospomindmap/deploys/65fd9e03be3f1e0008a8f481

@anajsana anajsana added the ospo-book issues related to ospo book project label Mar 22, 2024
Copy link
Contributor

@cjyabraham cjyabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anajsana
Copy link
Member

Thanks for the review @cjyabraham ! Merging!

@anajsana anajsana merged commit ba67c7d into todogroup:main Mar 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ospo-book issues related to ospo book project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants