Fix the Makefile to work with the install instructions in the README #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello LeLobster,
just a comment regarding DESTDIR!
LeLobster writes:
[...]
Also removed all the references to `DESTDIR` because that was not used at all and did nothing.
[...]
This is often used in order to install software in a staging directory
and in some package systems all packages actually need to support
DESTDIR. I think it is better to keep it.
|
|
I did not know that. EDIT -> No idea why I named it |
|
On second thought, after I did some reading about the Makefile standards on How about just adding a check if those dirs are passed on the command line and assign them to |
yuvalif
reviewed
Oct 4, 2018
|
Thoughts @inkarkat? It looks good to me at first glance. |
wwalker
pushed a commit
to wwalker/todo.txt-cli
that referenced
this pull request
Sep 19, 2021
…odotxt#259) * Fix the Makefile to work with the install instructions in the README * Put back DEST_DIR * Add simple ifdef checks to see if the user has set custom dirs via the commandline * Update README to match Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done:
master.fixes #XXreference to the issue that this pull request fixes.First time working with a Makefile but all I did was fix it so the instructions in the README actually work.
INSTALL_DIR, CONFIG_DIR & BASH_COMPLETIONwere not used in the original Makefile, instead there werebindir, sysconfdir & datarootdir.Also removed all the references to
DESTDIRbecause that was not used at all and did nothing.The default install location is still the same as I've changed nothing besides naming.