Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: replace hardcoded path to command substitution #375

Closed
wants to merge 1 commit into from
Closed

README.md: replace hardcoded path to command substitution #375

wants to merge 1 commit into from

Conversation

reishoku
Copy link

@reishoku reishoku commented Jan 12, 2022

This patch replaces hardcoded path in README.md. Since Homebrew (or Linuxbrew) can be installed anywhere on user's system, use of hard-coded path should be avoided.

Signed-off-by: KOSHIKAWA Kenichi <reishoku.misc at pm.me>


Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Format your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
  • Steps for the reviewer(s) on how they can manually QA the changes.
  • Have a fixes #XX reference to the issue that this pull request fixes.

Signed-off-by: KOSHIKAWA Kenichi <reishoku.misc@pm.me>
Copy link
Member

@karbassi karbassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a great PR. 👍

@reishoku reishoku closed this by deleting the head repository May 15, 2023
@inkarkat
Copy link
Member

@karbassi Can we please tackle the huge backlogs of PRs really soon?! We're already losing some valuable contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants