Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caption for video link #4

Closed
michaellwest opened this issue Jan 3, 2016 · 4 comments
Closed

Caption for video link #4

michaellwest opened this issue Jan 3, 2016 · 4 comments

Comments

@michaellwest
Copy link

Thank you for publishing this great plugin. I have a scenario which I think previously worked.

Can you support something like this? Basically I need a thumbnail with a video link that opens in a new tab.

[![SPE Remoting Module](http://img.youtube.com/vi/fGvT8eDdWrg/0.jpg)](http://www.youtube.com/watch?v=fGvT8eDdWrg "Click for a quick demo")

image

@todvora
Copy link
Owner

todvora commented Jan 4, 2016

Hi Michael,
Thank you for reporting this issue. You are right, it has been working earlier. It should be fixed now in the release 0.3.1. You can try it using the latest release or force gitbook to use exactly 0.3.1 by defining this in your book.json:

{
    "plugins": ["image-captions@0.3.1" ]
}

Real working example of your code can be seen on https://tdvorak.gitbooks.io/test-book/content/phetchaburi.html

I used your example also in tests to prevent any similar bug in future. Is it ok for you?

Thanks,
Tomas

@michaellwest
Copy link
Author

Hey that's great! Thank you for the quick turnaround. I'll test later by rebuilding my book.Feel free to use the example for your tests.

@todvora todvora closed this as completed Jan 4, 2016
@michaellwest
Copy link
Author

Back in action. Thanks!

@todvora
Copy link
Owner

todvora commented Jan 6, 2016

👍 Glad I could help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants