fix(electron): add dedicated api for opening external links in the de…

…fault browser (#6166)
toeverything · Mar 18, 2024 · 386bd03 · 386bd03
1 parent 8301d82
commit 386bd03
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/frontend/core/src/utils/cloud-utils.tsx b/packages/frontend/core/src/utils/cloud-utils.tsx
@@ -1,3 +1,4 @@
+import { apis } from '@affine/electron-api';
 import {
   generateRandUTF16Chars,
   getBaseUrl,
@@ -62,13 +63,12 @@ export const signInCloud = async (
       .catch(err => onRejectHandleTrace(err, traceParams));
   } else if (OAuthProviderType[provider]) {
     if (environment.isDesktop) {
-      open(
+      await apis?.ui.openExternal(
         `${
           runtimeConfig.serverUrlPrefix
         }/desktop-signin?provider=${provider}&redirect_uri=${buildRedirectUri(
           '/open-app/signin-redirect'
-        )}`,
-        '_target'
+        )}`
       );
     } else {
       location.href = `${

diff --git a/packages/frontend/electron/src/main/ui/handlers.ts b/packages/frontend/electron/src/main/ui/handlers.ts
@@ -1,4 +1,4 @@
-import { app, nativeTheme } from 'electron';
+import { app, nativeTheme, shell } from 'electron';
 import { getLinkPreview } from 'link-preview-js';
 
 import { isMacOS } from '../../shared/utils';
@@ -122,4 +122,7 @@ export const uiHandlers = {
       };
     }
   },
+  openExternal(_, url: string) {
+    return shell.openExternal(url);
+  },
 } satisfies NamespaceHandlers;