Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): add dedicated api for opening external links in the default browser #6166

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 18, 2024

No description provided.

Copy link

graphite-app bot commented Mar 18, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added app:electron Related to electron app app:core labels Mar 18, 2024
@pengx17 pengx17 requested a review from EYHN March 18, 2024 05:58
@pengx17 pengx17 marked this pull request as ready for review March 18, 2024 05:58
Copy link

nx-cloud bot commented Mar 18, 2024

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.46%. Comparing base (8301d82) to head (386bd03).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6166      +/-   ##
==========================================
- Coverage   60.47%   60.46%   -0.01%     
==========================================
  Files         497      496       -1     
  Lines       22470    22469       -1     
  Branches     2007     2007              
==========================================
- Hits        13588    13587       -1     
  Misses       8653     8653              
  Partials      229      229              
Flag Coverage Δ
server-test 70.16% <ø> (ø)
unittest 39.59% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 18, 2024

Merge activity

EYHN pushed a commit that referenced this pull request Mar 18, 2024
@EYHN EYHN force-pushed the 03-18-fix_electron_add_dedicated_api_for_opening_external_links_in_the_default_browser branch from abf214b to b47c0ee Compare March 18, 2024 06:39
@EYHN EYHN force-pushed the 03-18-fix_electron_add_dedicated_api_for_opening_external_links_in_the_default_browser branch from b47c0ee to 386bd03 Compare March 18, 2024 06:42
@graphite-app graphite-app bot merged commit 386bd03 into canary Mar 18, 2024
39 of 41 checks passed
@graphite-app graphite-app bot deleted the 03-18-fix_electron_add_dedicated_api_for_opening_external_links_in_the_default_browser branch March 18, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants