fix(core): fix flaky e2e (#6293)

toeverything · Mar 25, 2024 · 82cacd0 · 82cacd0
1 parent 578d4c9
commit 82cacd0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/packages/frontend/core/src/components/affine/page-history-modal/history-modal.tsx b/packages/frontend/core/src/components/affine/page-history-modal/history-modal.tsx
@@ -137,7 +137,7 @@ const HistoryEditorPreview = ({
         {snapshotPage ? (
           <AffineErrorBoundary>
             <Scrollable.Root>
-              <Scrollable.Viewport>
+              <Scrollable.Viewport className="affine-page-viewport">
                 <BlockSuiteEditor
                   className={styles.editor}
                   mode={mode}
@@ -165,7 +165,7 @@ const HistoryEditorPreview = ({
 
   return (
     <div className={styles.previewWrapper}>
-      {historyList.map((item, i) => {
+      {historyList.map((_item, i) => {
         const historyIndex = historyList.findIndex(h => h.timestamp === ts);
         const distance = i - historyIndex;
         const flag =
@@ -175,11 +175,7 @@ const HistoryEditorPreview = ({
               ? '< -20'
               : distance.toString();
         return (
-          <div
-            data-distance={flag}
-            key={item.id}
-            className={styles.previewContainer}
-          >
+          <div data-distance={flag} key={i} className={styles.previewContainer}>
             {historyIndex === i ? content : null}
           </div>
         );

diff --git a/tests/affine-cloud/e2e/page-history.spec.ts b/tests/affine-cloud/e2e/page-history.spec.ts
@@ -98,14 +98,23 @@ test('can restore page to a history version', async ({ page }) => {
   await pushCurrentPageUpdates(page);
 
   const title = getBlockSuiteEditorTitle(page);
+
+  await title.focus();
+
   await title.pressSequentially('TEST TITLE', {
     delay: 50,
   });
 
   // write something and push to history
   await pushCurrentPageUpdates(page);
 
-  await title.fill('New Title');
+  await title.selectText();
+
+  await title.press('Backspace');
+
+  await title.pressSequentially('New Title', {
+    delay: 50,
+  });
 
   // click the history button
   await page.getByTestId('header-dropDownButton').click();