Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete last workspace - no prompt for user #2402

Closed
ShortCipher5 opened this issue May 17, 2023 · 4 comments · Fixed by #2537 or #2587
Closed

Cannot delete last workspace - no prompt for user #2402

ShortCipher5 opened this issue May 17, 2023 · 4 comments · Fixed by #2537 or #2587
Assignees
Labels
beta Issues should be fixed for current Beta release. type:bug
Milestone

Comments

@ShortCipher5
Copy link
Contributor

When trying to delete the last workspace it will not be deleted - but the user is not informed of the reason.

If the user cannot delete the last workspace - they should receive a notification or message telling them so.

LastDelete

@ShortCipher5 ShortCipher5 added type:bug beta Issues should be fixed for current Beta release. labels May 17, 2023
@xell
Copy link

xell commented May 17, 2023

In fact there is a warning tip:

Image

However, I think the procedure can be optimized to not bother the user so much. If it's the only one workspace, the Delete button in the Delete Workspace should be disabled at all. And the "You cannot delete the last workspace" annotation should be highlighted somewhere in the description area. CC @Svaney-ssman to offer a design plan.

@Svaney-ssman
Copy link

Internal figma link
image

@himself65
Copy link
Contributor

The reason is AFFiNE needs one workspace so that we can display the correct UI. And When it's 0 workspaces, the code will crash. I think it needs a discussion by @joebeijing whether redirect the page to a create workspace page or prohibit deleting the last one

@houjoe0829
Copy link

@himself65
Based on the current implementation, the last workspace cannot be deleted and a Toast message will appear. According to the original design, the expected effect was that the last workspace could be deleted, but the My Workspaces page would then pop up and cannot be closed unless a new workspace is created.

CleanShot 2023-05-29 at 5 13 43@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Issues should be fixed for current Beta release. type:bug
Projects
Archived in project
5 participants