Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot delete last workspace #2537

Merged
merged 1 commit into from May 26, 2023
Merged

Conversation

himself65
Copy link
Contributor

Fixes: #2402, #2531

@himself65 himself65 requested a review from JimmFly as a code owner May 26, 2023 04:52
@codesandbox
Copy link

codesandbox bot commented May 26, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@himself65 himself65 temporarily deployed to development May 26, 2023 04:52 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 04:52 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 5:01am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 5:01am

@himself65 himself65 temporarily deployed to development May 26, 2023 04:52 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 04:52 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 04:52 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09 ⚠️

Comparison is base (b11ce2c) 72.59% compared to head (1d24de8) 72.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2537      +/-   ##
==========================================
- Coverage   72.59%   72.50%   -0.09%     
==========================================
  Files         317      317              
  Lines        7054     7057       +3     
  Branches     1145     1146       +1     
==========================================
- Hits         5121     5117       -4     
- Misses       1732     1737       +5     
- Partials      201      203       +2     
Flag Coverage Δ
e2etest 66.30% <100.00%> (-0.01%) ⬇️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 47.49% <100.00%> (-0.48%) ⬇️
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
storybook-test 55.07% <ø> (-0.19%) ⬇️
unittest 37.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nents/affine/workspace-setting-detail/index.css.ts 100.00% <ø> (ø)
...e/workspace-setting-detail/panel/general/index.tsx 73.07% <100.00%> (+1.07%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development May 26, 2023 04:55 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 04:56 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 04:56 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 04:56 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 04:56 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 04:56 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 04:56 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 04:56 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 26, 2023 04:56 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 26, 2023 04:56 Inactive
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1d24de8
Status: ✅  Deploy successful!
Preview URL: https://068c81bd.affine.pages.dev
Branch Preview URL: https://himself65-delete-last-worksp.affine.pages.dev

View logs

@perfsee
Copy link

perfsee bot commented May 26, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …ast-workspace                 +/- ##
===================================================================
< Bundle              3.34 MB        3.34 MB      +328 B(+0.01%)   
< Initial JS          2.08 MB        2.08 MB      +286 B(+0.01%)   
< Initial CSS         35.6 kB        35.6 kB       +42 B(+0.12%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   47             47                       
= Chunks                   40             40                       
= Packages                144            144                       
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …ast-workspace                 +/- ##
===================================================================
< Bundle              3.21 MB        3.21 MB      +328 B(+0.01%)   
< Initial JS          1.96 MB        1.96 MB      +286 B(+0.01%)   
< Initial CSS         35.6 kB        35.6 kB       +42 B(+0.12%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   45             45                       
= Chunks                   38             38                       
= Packages                144            144                       
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …ast-workspace                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 26, 2023 05:01 Inactive
@himself65 himself65 enabled auto-merge (squash) May 26, 2023 05:04
@himself65 himself65 disabled auto-merge May 26, 2023 05:04
@himself65 himself65 merged commit 60057c6 into master May 26, 2023
12 checks passed
@himself65 himself65 deleted the himself65/delete-last-workspace branch May 26, 2023 05:04
himself65 added a commit that referenced this pull request May 26, 2023
himself65 added a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:web mod:i18n Related to i18n
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cannot delete last workspace - no prompt for user
2 participants