Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logic after delete all workspaces #2587

Merged
merged 12 commits into from
May 31, 2023
Merged

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented May 30, 2023

Fixes: #2402

@himself65 himself65 requested a review from JimmFly as a code owner May 30, 2023 04:27
@codesandbox
Copy link

codesandbox bot commented May 30, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@himself65 himself65 temporarily deployed to development May 30, 2023 04:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 30, 2023 04:27 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 4:19am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 4:19am

@himself65 himself65 temporarily deployed to development May 30, 2023 04:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 30, 2023 04:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 30, 2023 04:27 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 30, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e4f245c
Status: ✅  Deploy successful!
Preview URL: https://0c78c739.affine.pages.dev
Branch Preview URL: https://himself65-0530-first-workspa.affine.pages.dev

View logs

@himself65 himself65 temporarily deployed to development May 30, 2023 04:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 30, 2023 04:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 30, 2023 04:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 30, 2023 04:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 30, 2023 04:29 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: +0.03 🎉

Comparison is base (1c7ae04) 68.66% compared to head (e4f245c) 68.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2587      +/-   ##
==========================================
+ Coverage   68.66%   68.70%   +0.03%     
==========================================
  Files         336      336              
  Lines        7685     7684       -1     
  Branches     1235     1236       +1     
==========================================
+ Hits         5277     5279       +2     
+ Misses       2140     2138       -2     
+ Partials      268      267       -1     
Flag Coverage Δ
e2etest 62.37% <91.66%> (+0.01%) ⬆️
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 45.45% <75.00%> (+0.06%) ⬆️
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
storybook-test 49.92% <ø> (ø)
unittest 51.30% <80.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/workspace-setting-detail/panel/general/index.tsx 77.27% <ø> (-0.99%) ⬇️
packages/workspace/src/atom.ts 84.84% <50.00%> (-2.25%) ⬇️
apps/web/src/providers/modal-provider.tsx 89.58% <93.33%> (-0.22%) ⬇️
apps/web/src/atoms/index.ts 96.07% <100.00%> (+0.16%) ⬆️
apps/web/src/layouts/workspace-layout.tsx 90.74% <100.00%> (+1.36%) ⬆️
apps/web/src/pages/index.tsx 65.62% <100.00%> (ø)
.../web/src/pages/workspace/[workspaceId]/setting.tsx 61.90% <100.00%> (+3.20%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development May 30, 2023 04:33 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 30, 2023 04:33 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 30, 2023 04:33 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 30, 2023 04:33 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 30, 2023 04:33 — with GitHub Actions Inactive
@github-actions github-actions bot added the test label May 30, 2023
@himself65 himself65 temporarily deployed to development May 30, 2023 04:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 31, 2023 03:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 31, 2023 03:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 31, 2023 03:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 31, 2023 03:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 31, 2023 03:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 31, 2023 03:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 31, 2023 03:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 31, 2023 03:59 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 31, 2023 04:02 Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:07 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 31, 2023 04:09 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 31, 2023 04:15 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 31, 2023 04:19 Inactive
@himself65 himself65 merged commit 8dbd354 into master May 31, 2023
@himself65 himself65 deleted the himself65/0530-first-workspace branch May 31, 2023 04:24
himself65 added a commit that referenced this pull request May 31, 2023
Co-authored-by: JimmFly <yangjinfei001@gmail.com>
himself65 added a commit that referenced this pull request Jun 2, 2023
Co-authored-by: JimmFly <yangjinfei001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:web mod:i18n Related to i18n mod:store mod:workspace Related to workspace
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cannot delete last workspace - no prompt for user
2 participants