Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some minor ui issues #2058

Merged
merged 2 commits into from
Apr 21, 2023
Merged

fix: some minor ui issues #2058

merged 2 commits into from
Apr 21, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Apr 21, 2023

No description provided.

@pengx17 pengx17 requested a review from himself65 April 21, 2023 03:16
@pengx17 pengx17 temporarily deployed to development April 21, 2023 03:16 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 21, 2023 4:59am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2023 4:59am

@pengx17 pengx17 temporarily deployed to development April 21, 2023 03:16 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 21, 2023 03:16 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 21, 2023 03:16 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 21, 2023 03:16 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 21, 2023 03:16 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 21, 2023 03:19 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3fdd45b
Status: ✅  Deploy successful!
Preview URL: https://39fc06e7.affine.pages.dev
Branch Preview URL: https://0421-fix-minor-ui-issues.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-storybook April 21, 2023 03:20 Inactive
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.03 🎉

Comparison is base (01115f8) 75.55% compared to head (3fdd45b) 75.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2058      +/-   ##
==========================================
+ Coverage   75.55%   75.59%   +0.03%     
==========================================
  Files         296      296              
  Lines        5870     5871       +1     
  Branches     1079     1073       -6     
==========================================
+ Hits         4435     4438       +3     
+ Misses       1196     1193       -3     
- Partials      239      240       +1     
Flag Coverage Δ
e2etest 73.79% <100.00%> (+0.08%) ⬆️
server-test 90.78% <ø> (ø)
storybook-test 49.05% <ø> (ø)
unittest 44.96% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ps/web/src/components/pure/loading/PageLoading.tsx 100.00% <ø> (ø)
.../block-suite-page-list/page-list/OperationCell.tsx 56.09% <50.00%> (-1.41%) ⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview – affine-preview April 21, 2023 03:22 Inactive
@himself65 himself65 temporarily deployed to development April 21, 2023 04:42 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 21, 2023 04:42 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 21, 2023 04:42 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 21, 2023 04:42 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 21, 2023 04:42 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 21, 2023 04:42 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 21, 2023 04:46 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 21, 2023 04:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 21, 2023 04:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 21, 2023 04:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 21, 2023 04:51 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 21, 2023 04:55 Inactive
@perfsee
Copy link

perfsee bot commented Apr 21, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …nor-ui-issues                 +/- ##
===================================================================
< Bundle              4.26 MB        4.26 MB       +71 B(+0.00%)   
< Initial JS          1.74 MB        1.74 MB       +71 B(+0.00%)   
= Initial CSS         13.1 kB        13.1 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …nor-ui-issues                 +/- ##
===================================================================
< Bundle              4.15 MB        4.15 MB       +71 B(+0.00%)   
< Initial JS          1.64 MB        1.64 MB       +71 B(+0.00%)   
= Initial CSS         13.1 kB        13.1 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …nor-ui-issues                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview April 21, 2023 04:59 Inactive
@himself65 himself65 merged commit 5a12483 into master Apr 21, 2023
19 of 20 checks passed
@himself65 himself65 deleted the 0421/fix/minor-ui-issues branch April 21, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants