Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some minor ui issues #2058

Merged
merged 2 commits into from
Apr 21, 2023
Merged

fix: some minor ui issues #2058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4af575
fix: some minor ui issues
pengx17 Apr 21, 2023
3fdd45b
Merge branch 'master' into 0421/fix/minor-ui-issues
himself65 Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions apps/web/src/components/blocksuite/block-suite-page-list/page-list/OperationCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,16 @@ export const OperationCell: React.FC<OperationCellProps> = ({
>
{favorite ? t('Remove from favorites') : t('Add to Favorites')}
</MenuItem>
<MenuItem
onClick={() => {
onOpenPageInNewTab(id);
}}
icon={<OpenInNewIcon />}
>
{t('Open in new tab')}
</MenuItem>
{!environment.isDesktop && (
<MenuItem
onClick={() => {
onOpenPageInNewTab(id);
}}
icon={<OpenInNewIcon />}
>
{t('Open in new tab')}
</MenuItem>
)}
{!pageMeta.isRootPinboard && (
<MoveTo
metas={metas}
Expand Down
7 changes: 3 additions & 4 deletions apps/web/src/components/pure/loading/PageLoading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const StyledLoadingContainer = styled('div')(() => {
justifyContent: 'center',
alignItems: 'center',
color: '#6880FF',
flexDirection: 'column',
h1: {
fontSize: '2em',
marginTop: '15px',
Expand All @@ -38,10 +39,8 @@ export const PageLoading = ({ text }: { text?: string }) => {
const { t } = useTranslation();
return (
<StyledLoadingContainer>
<div className="wrapper">
<Loading />
<h1>{text ? text : t('Loading')}</h1>
</div>
<Loading />
<h1>{text ? text : t('Loading')}</h1>
</StyledLoadingContainer>
);
};
Expand Down