Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename WorkspacePlugin to WorkspaceAdapter #2330

Merged
merged 1 commit into from
May 11, 2023

Conversation

himself65
Copy link
Contributor

No description provided.

@codesandbox
Copy link

codesandbox bot commented May 11, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 5:37pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 5:37pm

@himself65 himself65 temporarily deployed to development May 11, 2023 17:24 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:24 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:24 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:24 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:24 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:24 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:29 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 11, 2023 17:29 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 93.54% and project coverage change: -0.17 ⚠️

Comparison is base (39c83bd) 70.81% compared to head (ccd3f74) 70.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2330      +/-   ##
==========================================
- Coverage   70.81%   70.65%   -0.17%     
==========================================
  Files         324      324              
  Lines        7202     7207       +5     
  Branches     1144     1144              
==========================================
- Hits         5100     5092       -8     
- Misses       1890     1900      +10     
- Partials      212      215       +3     
Flag Coverage Δ
e2etest 66.99% <91.66%> (-0.29%) ⬇️
server-test 73.14% <ø> (ø)
storybook-test 54.84% <100.00%> (ø)
unittest 40.44% <57.14%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/workspace-setting-detail/panel/publish/index.tsx 78.12% <ø> (ø)
...workspace-header/header-right-items/share-menu.tsx 52.94% <ø> (ø)
...src/components/pure/workspace-list-modal/index.tsx 81.81% <ø> (ø)
apps/web/src/hooks/affine/use-affine-log-in.ts 50.00% <0.00%> (ø)
...b/src/hooks/affine/use-toggle-workspace-publish.ts 100.00% <ø> (ø)
apps/web/src/plugins/affine/fetcher.ts 8.10% <0.00%> (ø)
apps/web/src/shared/index.ts 73.68% <ø> (ø)
...component/src/components/share-menu/share-menu.tsx 73.91% <ø> (ø)
...omponent/src/components/workspace-avatar/index.tsx 90.90% <ø> (ø)
.../component/src/components/workspace-card/index.tsx 74.28% <ø> (ø)
... and 16 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ccd3f74
Status: ✅  Deploy successful!
Preview URL: https://378938a1.affine.pages.dev
Branch Preview URL: https://himself65-0511-workspace-ren.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 11, 2023 17:33 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 11, 2023 17:37 Inactive
@perfsee
Copy link

perfsee bot commented May 11, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …kspace-rename                 +/- ##
===================================================================
< Bundle              3.11 MB        3.16 MB    +51.6 kB(+1.66%)   
< Initial JS          1.86 MB        1.87 MB    +9.99 kB(+0.54%)   
< Initial CSS         16.8 kB        27.5 kB   +10.7 kB(+63.91%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             49                  +8   
< Chunks                   39             43                  +4   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …kspace-rename                 +/- ##
===================================================================
< Bundle                 3 MB        3.04 MB    +42.2 kB(+1.41%)   
< Initial JS          1.75 MB        1.75 MB      +556 B(+0.03%)   
< Initial CSS         16.8 kB        27.5 kB   +10.7 kB(+63.91%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             47                  +8   
< Chunks                   37             41                  +4   
< Packages                132            134                  +2   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …kspace-rename                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@himself65 himself65 merged commit 063ffda into master May 11, 2023
11 checks passed
@himself65 himself65 deleted the himself65/0511-workspace-rename branch May 11, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant