Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new page button #2417

Merged
merged 7 commits into from
May 18, 2023
Merged

feat: add new page button #2417

merged 7 commits into from
May 18, 2023

Conversation

lawvs
Copy link
Member

@lawvs lawvs commented May 17, 2023

Screen.Recording.2023-05-17.at.5.59.48.PM.mov

@lawvs lawvs requested a review from JimmFly as a code owner May 17, 2023 10:00
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4b47ccc
Status: ✅  Deploy successful!
Preview URL: https://1d9747cc.affine.pages.dev
Branch Preview URL: https://feat-new-page-button.affine.pages.dev

View logs

@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 8:16am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 8:16am

@codesandbox
Copy link

codesandbox bot commented May 17, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@lawvs lawvs temporarily deployed to development May 17, 2023 10:00 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 17, 2023 10:00 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 17, 2023 10:00 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 17, 2023 10:00 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 17, 2023 10:00 — with GitHub Actions Inactive
@lawvs lawvs requested a review from pengx17 May 17, 2023 10:00
@lawvs lawvs temporarily deployed to development May 17, 2023 10:02 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 81.08% and project coverage change: +0.33 🎉

Comparison is base (34ff08b) 72.46% compared to head (4b47ccc) 72.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2417      +/-   ##
==========================================
+ Coverage   72.46%   72.80%   +0.33%     
==========================================
  Files         311      315       +4     
  Lines        6974     7034      +60     
  Branches     1148     1149       +1     
==========================================
+ Hits         5054     5121      +67     
+ Misses       1720     1714       -6     
+ Partials      200      199       -1     
Flag Coverage Δ
e2etest 66.37% <92.59%> (+0.37%) ⬆️
e2etest-macos-latest-x64 ∅ <ø> (?)
e2etest-ubuntu-latest-x64 47.52% <29.62%> (-0.12%) ⬇️
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-test 73.12% <ø> (ø)
storybook-test 57.28% <65.71%> (+1.52%) ⬆️
unittest 37.40% <22.03%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/web/src/atoms/index.ts 95.83% <ø> (ø)
...onent/src/components/card/block-card/styles.css.ts 100.00% <ø> (ø)
packages/component/src/ui/table/styles.ts 100.00% <ø> (ø)
...ages/hooks/src/use-block-suite-workspace-helper.ts 82.35% <ø> (ø)
...ponents/blocksuite/block-suite-page-list/index.tsx 69.64% <33.33%> (-5.36%) ⬇️
packages/component/src/ui/menu/menu.tsx 57.14% <50.00%> (-17.86%) ⬇️
...es/component/src/components/page-list/all-page.tsx 76.00% <71.42%> (+1.00%) ⬆️
...nent/src/components/page-list/new-page-buttton.tsx 72.72% <72.72%> (ø)
...ponents/blocksuite/block-suite-page-list/utils.tsx 100.00% <100.00%> (ø)
apps/web/src/components/root-app-sidebar/index.tsx 83.78% <100.00%> (ø)
... and 3 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lawvs lawvs temporarily deployed to development May 17, 2023 10:06 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 17, 2023 10:06 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 17, 2023 10:06 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 17, 2023 10:06 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 17, 2023 10:06 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 17, 2023 10:06 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 17, 2023 10:06 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 17, 2023 10:06 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 17, 2023 10:27 Inactive
@perfsee
Copy link

perfsee bot commented May 17, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …w-page-button                 +/- ##
===================================================================
< Bundle              3.11 MB        3.27 MB     +161 kB(+5.17%)   
< Initial JS          1.86 MB        2.05 MB    +194 kB(+10.42%)   
< Initial CSS         16.8 kB        34.1 kB  +17.3 kB(+103.37%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             46                  +5   
= Chunks                   39             39                       
< Packages                132            143                 +11   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …w-page-button                 +/- ##
===================================================================
< Bundle                 3 MB        3.15 MB     +151 kB(+5.05%)   
< Initial JS          1.75 MB        1.93 MB    +184 kB(+10.55%)   
< Initial CSS         16.8 kB        34.1 kB  +17.3 kB(+103.37%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             44                  +5   
= Chunks                   37             37                       
< Packages                132            143                 +11   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …w-page-button                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 17, 2023 10:31 Inactive
Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test needed

@lawvs lawvs temporarily deployed to development May 18, 2023 07:12 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 07:12 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 07:12 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 07:12 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 07:12 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 18, 2023 07:16 Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 08:01 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 08:01 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 08:01 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 08:01 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 08:01 — with GitHub Actions Inactive
@lawvs lawvs requested a review from himself65 May 18, 2023 08:01
@github-actions github-actions bot added the test label May 18, 2023
@lawvs lawvs temporarily deployed to development May 18, 2023 08:03 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 08:05 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 08:05 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 08:05 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 08:05 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 08:05 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 08:05 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 08:05 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 18, 2023 08:05 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 18, 2023 08:12 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 18, 2023 08:16 Inactive
@himself65 himself65 merged commit 530dd5f into master May 18, 2023
10 checks passed
@himself65 himself65 deleted the feat/new-page-button branch May 18, 2023 20:07
himself65 pushed a commit that referenced this pull request May 25, 2023
himself65 pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants