Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configurable changelog url #2418

Merged
merged 7 commits into from May 17, 2023
Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 17, 2023

also fix #2419

@codesandbox
Copy link

codesandbox bot commented May 17, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 10:31pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 10:31pm

@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:38 — with GitHub Actions Inactive
@pengx17 pengx17 requested a review from himself65 May 17, 2023 12:38
@pengx17 pengx17 requested a review from Brooooooklyn May 17, 2023 12:38
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:41 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 28.57% and project coverage change: -0.09 ⚠️

Comparison is base (6c31024) 72.23% compared to head (2533533) 72.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2418      +/-   ##
==========================================
- Coverage   72.23%   72.15%   -0.09%     
==========================================
  Files         313      294      -19     
  Lines        6959     5908    -1051     
  Branches     1141     1107      -34     
==========================================
- Hits         5027     4263     -764     
+ Misses       1730     1447     -283     
+ Partials      202      198       -4     
Flag Coverage Δ
e2etest 65.90% <0.00%> (+0.08%) ⬆️
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 47.93% <10.52%> (-0.06%) ⬇️
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-test ?
storybook-test 55.30% <0.00%> (-0.04%) ⬇️
unittest 37.26% <5.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eb/src/components/affine/affine-error-eoundary.tsx 50.00% <ø> (+20.83%) ⬆️
...space-setting-detail/panel/collaboration/index.tsx 52.94% <ø> (ø)
...e/workspace-setting-detail/panel/publish/index.tsx 78.12% <ø> (ø)
...workspace-header/header-right-items/share-menu.tsx 58.82% <ø> (ø)
apps/web/src/components/page-detail-editor.tsx 81.81% <ø> (ø)
apps/web/src/components/pure/help-island/index.tsx 90.00% <ø> (ø)
...s/web/src/pages/public-workspace/[workspaceId].tsx 82.85% <ø> (ø)
...web/src/pages/workspace/[workspaceId]/[pageId].tsx 70.45% <ø> (ø)
apps/web/src/pages/workspace/[workspaceId]/all.tsx 73.91% <ø> (ø)
.../web/src/pages/workspace/[workspaceId]/setting.tsx 64.70% <ø> (ø)
... and 8 more

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:43 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:43 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:43 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:43 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:43 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:43 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:43 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:43 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2533533
Status:🚫  Build failed.

View logs

@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:49 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:49 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:49 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 17, 2023 12:49 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:24 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:25 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 17, 2023 22:26 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 17, 2023 22:31 Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 17, 2023 22:50 — with GitHub Actions Inactive
@pengx17 pengx17 merged commit f875b37 into master May 17, 2023
8 of 9 checks passed
@pengx17 pengx17 deleted the 0517/fix/updater-changelog-url branch May 17, 2023 23:16
himself65 pushed a commit that referenced this pull request May 18, 2023
himself65 pushed a commit that referenced this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
2 participants