Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused i18n key #2451

Merged
merged 1 commit into from
May 19, 2023
Merged

chore: remove unused i18n key #2451

merged 1 commit into from
May 19, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 19, 2023

Close #2446

@codesandbox
Copy link

codesandbox bot commented May 19, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:23 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 3:29am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 3:29am

@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:23 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:23 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:23 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:23 — with GitHub Actions Inactive
@JimmFly JimmFly enabled auto-merge (squash) May 19, 2023 03:23
@github-actions github-actions bot added the mod:i18n Related to i18n label May 19, 2023
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 19, 2023 03:25 Inactive
@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:26 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (530dd5f) 72.76% compared to head (7fc7d16) 72.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2451      +/-   ##
==========================================
- Coverage   72.76%   72.75%   -0.02%     
==========================================
  Files         315      315              
  Lines        7035     7035              
  Branches     1147     1147              
==========================================
- Hits         5119     5118       -1     
- Misses       1715     1717       +2     
+ Partials      201      200       -1     
Flag Coverage Δ
e2etest 66.29% <ø> (-0.03%) ⬇️
e2etest-macos-latest-x64 ∅ <ø> (?)
e2etest-ubuntu-latest-x64 47.40% <ø> (-0.05%) ⬇️
server-test 73.12% <ø> (ø)
storybook-test 57.21% <ø> (ø)
unittest 37.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7fc7d16
Status: ✅  Deploy successful!
Preview URL: https://bd3193a0.affine.pages.dev
Branch Preview URL: https://chore-remove-unused-i18nkey.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:28 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:28 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:28 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:28 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:28 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:28 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:28 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 19, 2023 03:28 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 19, 2023 03:29 Inactive
@perfsee
Copy link

perfsee bot commented May 19, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …nused-i18nkey                 +/- ##
===================================================================
< Bundle              3.11 MB        3.29 MB     +185 kB(+5.96%)   
< Initial JS          1.86 MB        2.08 MB    +218 kB(+11.71%)   
< Initial CSS         16.8 kB        34.6 kB  +17.8 kB(+106.32%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             46                  +5   
= Chunks                   39             39                       
< Packages                132            143                 +11   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …nused-i18nkey                 +/- ##
===================================================================
< Bundle                 3 MB        3.17 MB     +176 kB(+5.86%)   
< Initial JS          1.75 MB        1.96 MB    +208 kB(+11.92%)   
< Initial CSS         16.8 kB        34.6 kB  +17.8 kB(+106.32%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             44                  +5   
= Chunks                   37             37                       
< Packages                132            143                 +11   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …nused-i18nkey                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@JimmFly JimmFly merged commit c82fb89 into master May 19, 2023
12 checks passed
@JimmFly JimmFly deleted the chore/remove-unused-i18nkey branch May 19, 2023 03:38
himself65 pushed a commit that referenced this pull request May 25, 2023
himself65 pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:i18n Related to i18n
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Found typo?
2 participants