fix: optimize app updater #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying with
|
| Latest commit: |
ba506eb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e03962d7.affine.pages.dev |
| Branch Preview URL: | https://xp-0519-fix-styles.affine.pages.dev |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2452 +/- ##
==========================================
+ Coverage 72.75% 72.80% +0.05%
==========================================
Files 315 315
Lines 7035 7034 -1
Branches 1147 1147
==========================================
+ Hits 5118 5121 +3
+ Misses 1716 1715 -1
+ Partials 201 198 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
affine-toeverythingBundle maindiff ------------------- Bundle Size Diff -------------------------
@@ EntryPoint: main @@
## master …19/fix/styles +/- ##
===================================================================
< Bundle 3.11 MB 3.31 MB +198 kB(+6.37%)
< Initial JS 1.86 MB 2.08 MB +221 kB(+11.87%)
< Initial CSS 16.8 kB 35.3 kB +18.6 kB(+110.79%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets 41 47 +6
< Chunks 39 40 +1
< Packages 132 145 +13
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid cache wasting
@@ EntryPoint: pages/_app @@
## master …19/fix/styles +/- ##
===================================================================
< Bundle 3 MB 3.19 MB +189 kB(+6.29%)
< Initial JS 1.75 MB 1.96 MB +211 kB(+12.10%)
< Initial CSS 16.8 kB 35.3 kB +18.6 kB(+110.79%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets 39 45 +6
< Chunks 37 38 +1
< Packages 132 145 +13
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid cache wasting
@@ EntryPoint: pages/_error @@
## master …19/fix/styles +/- ##
===================================================================
= Bundle 16.6 kB 16.6 kB
= Initial JS 16.6 kB 16.6 kB
= Initial CSS 0 B 0 B
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 2 2
= Chunks 2 2
= Packages 5 5
= Duplicates 0 0
...and more |
himself65
approved these changes
May 19, 2023
Brooooooklyn
pushed a commit
that referenced
this pull request
May 19, 2023
himself65
pushed a commit
that referenced
this pull request
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 023ad39
This pull request adds collapsible functionality and animations to the favorite list component in the workspace slider bar, using the
@radix-ui/react-collapsibleand@vanilla-extract/csslibraries. It also improves the app updater button component by using standard CSS properties and pseudo-elements for the animation, and by dismissing the changelog modal when the button is clicked.