Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add responvise page view #2453

Merged
merged 10 commits into from
May 21, 2023
Merged

feat: add responvise page view #2453

merged 10 commits into from
May 21, 2023

Conversation

lawvs
Copy link
Member

@lawvs lawvs commented May 19, 2023

Fix #2379
Screenshot 2023-05-19 at 2 42 50 PM

Screen.Recording.2023-05-19.at.6.06.39.PM.mov

@codesandbox
Copy link

codesandbox bot commented May 19, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@lawvs lawvs temporarily deployed to development May 19, 2023 06:39 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:39 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 10:42am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 10:42am

@lawvs lawvs temporarily deployed to development May 19, 2023 06:39 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:39 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:39 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5e1e0ce
Status: ✅  Deploy successful!
Preview URL: https://ef257329.affine.pages.dev
Branch Preview URL: https://feat-responvise-page-view.affine.pages.dev

View logs

@lawvs lawvs temporarily deployed to development May 19, 2023 06:39 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:39 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:39 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:39 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:39 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 65.67% and project coverage change: -0.18 ⚠️

Comparison is base (ef2d135) 72.76% compared to head (5e1e0ce) 72.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2453      +/-   ##
==========================================
- Coverage   72.76%   72.59%   -0.18%     
==========================================
  Files         315      319       +4     
  Lines        7034     7034              
  Branches     1147     1145       -2     
==========================================
- Hits         5118     5106      -12     
- Misses       1716     1726      +10     
- Partials      200      202       +2     
Flag Coverage Δ
e2etest 66.16% <69.76%> (-0.15%) ⬇️
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 47.51% <30.23%> (+0.03%) ⬆️
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-test 73.12% <ø> (ø)
storybook-test 56.48% <67.30%> (-0.70%) ⬇️
unittest 37.44% <27.08%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/page-list/components/new-page-buttton.tsx 72.72% <ø> (ø)
...kages/component/src/components/page-list/styles.ts 87.50% <ø> (-12.50%) ⬇️
...ages/component/src/components/page-list/mobile.tsx 17.64% <17.64%> (ø)
...c/components/page-list/components/favorite-tag.tsx 69.23% <69.23%> (ø)
...es/component/src/components/page-list/all-page.tsx 80.95% <70.00%> (+4.95%) ⬆️
...ponent/src/components/page-list/all-pages-body.tsx 87.50% <87.50%> (ø)
...ponents/blocksuite/block-suite-page-list/utils.tsx 100.00% <100.00%> (ø)
...src/components/page-list/components/title-cell.tsx 100.00% <100.00%> (ø)
packages/component/src/ui/menu/menu.tsx 57.14% <100.00%> (ø)
packages/component/src/ui/table/styles.ts 100.00% <100.00%> (ø)
... and 4 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lawvs lawvs temporarily deployed to development May 19, 2023 06:43 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:44 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:44 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:44 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:44 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:44 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:44 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:44 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:44 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 19, 2023 06:51 Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:54 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:54 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:54 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 06:54 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 10:21 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 10:21 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 10:21 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 10:21 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 10:21 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 19, 2023 10:21 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 19, 2023 10:38 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 19, 2023 10:42 Inactive
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@lawvs lawvs requested a review from himself65 May 21, 2023 05:19
@lawvs lawvs temporarily deployed to development May 21, 2023 05:19 — with GitHub Actions Inactive
@himself65 himself65 merged commit d68b421 into master May 21, 2023
9 checks passed
@himself65 himself65 deleted the feat/responvise-page-view branch May 21, 2023 23:25
himself65 pushed a commit that referenced this pull request May 25, 2023
himself65 pushed a commit that referenced this pull request May 25, 2023
himself65 pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

All pages responsive design
2 participants