Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust some windows style issues #2454

Merged
merged 2 commits into from May 19, 2023
Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 19, 2023

No description provided.

@codesandbox
Copy link

codesandbox bot commented May 19, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:21 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:21 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 8:38am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 8:38am

@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:21 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:21 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:21 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5d69cfd
Status: ✅  Deploy successful!
Preview URL: https://7b91ae65.affine.pages.dev
Branch Preview URL: https://xp-0519-fix-win-styles.affine.pages.dev

View logs

@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:23 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:23 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:23 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:23 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:23 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.05 ⚠️

Comparison is base (ef2d135) 72.76% compared to head (5d69cfd) 72.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2454      +/-   ##
==========================================
- Coverage   72.76%   72.71%   -0.05%     
==========================================
  Files         315      315              
  Lines        7034     7036       +2     
  Branches     1147     1149       +2     
==========================================
- Hits         5118     5116       -2     
- Misses       1716     1720       +4     
  Partials      200      200              
Flag Coverage Δ
e2etest 66.28% <0.00%> (-0.03%) ⬇️
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 47.37% <0.00%> (-0.12%) ⬇️
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-test 73.12% <ø> (ø)
storybook-test 57.07% <50.00%> (-0.11%) ⬇️
unittest 37.34% <25.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/components/app-sidebar/sidebar-header/index.tsx 35.29% <33.33%> (-11.38%) ⬇️
...mponents/blocksuite/workspace-header/styles.css.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@perfsee
Copy link

perfsee bot commented May 19, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …ix/win-styles                 +/- ##
===================================================================
< Bundle              3.11 MB        3.31 MB     +198 kB(+6.37%)   
< Initial JS          1.86 MB        2.08 MB    +221 kB(+11.88%)   
< Initial CSS         16.8 kB        35.3 kB  +18.6 kB(+110.86%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             47                  +6   
< Chunks                   39             40                  +1   
< Packages                132            145                 +13   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …ix/win-styles                 +/- ##
===================================================================
< Bundle                 3 MB        3.19 MB     +189 kB(+6.29%)   
< Initial JS          1.75 MB        1.96 MB    +212 kB(+12.10%)   
< Initial CSS         16.8 kB        35.3 kB  +18.6 kB(+110.86%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             45                  +6   
< Chunks                   37             38                  +1   
< Packages                132            145                 +13   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …ix/win-styles                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 19, 2023 08:27 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 19, 2023 08:34 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 19, 2023 08:38 Inactive
@himself65 himself65 merged commit 66ea97c into master May 19, 2023
9 checks passed
@himself65 himself65 deleted the xp/0519/fix/win-styles branch May 19, 2023 16:39
himself65 pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants