feat: support bookmark #2458
Merged
feat: support bookmark #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2458 +/- ##
==========================================
- Coverage 72.60% 71.83% -0.77%
==========================================
Files 318 319 +1
Lines 7103 7211 +108
Branches 1161 1185 +24
==========================================
+ Hits 5157 5180 +23
- Misses 1744 1829 +85
Partials 202 202
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Deploying with
|
| Latest commit: |
8b663fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7970acf9.affine.pages.dev |
| Branch Preview URL: | https://feat-bookmark.affine.pages.dev |
affine-toeverythingBundle maindiff ------------------- Bundle Size Diff -------------------------
@@ EntryPoint: main @@
## master feat/bookmark +/- ##
===================================================================
< Bundle 3.34 MB 3.41 MB +73.1 kB(+2.19%)
< Initial JS 2.08 MB 2.16 MB +83.5 kB(+4.01%)
= Initial CSS 35.6 kB 35.6 kB
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 47 47
= Chunks 40 40
= Packages 144 144
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid cache wasting
@@ EntryPoint: pages/_app @@
## master feat/bookmark +/- ##
===================================================================
< Bundle 3.22 MB 3.29 MB +73.1 kB(+2.27%)
< Initial JS 1.96 MB 2.04 MB +83.5 kB(+4.26%)
= Initial CSS 35.6 kB 35.6 kB
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 45 45
= Chunks 38 38
= Packages 144 144
= Duplicates 3 3
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid cache wasting
@@ EntryPoint: pages/_error @@
## master feat/bookmark +/- ##
===================================================================
= Bundle 16.6 kB 16.6 kB
= Initial JS 16.6 kB 16.6 kB
= Initial CSS 0 B 0 B
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 2 2
= Chunks 2 2
= Packages 5 5
= Duplicates 0 0
...and more |
himself65
approved these changes
May 26, 2023
himself65
added a commit
that referenced
this pull request
May 26, 2023
Co-authored-by: himself65 <himself65@outlook.com>
himself65
added a commit
that referenced
this pull request
Jun 2, 2023
Co-authored-by: himself65 <himself65@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs to be linked with blocksuite. Ths specific requirements are here: toeverything/blocksuite#2574
What this pr has to do are: