Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add circular import detect #2475

Merged
merged 8 commits into from
May 22, 2023
Merged

ci: add circular import detect #2475

merged 8 commits into from
May 22, 2023

Conversation

Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented May 22, 2023

❯ yarn circular    
Processed 102 files (682ms) (121 warnings)

✖ Found 4 circular dependencies!

1) ../../../../packages/component/src/components/app-sidebar/fallback.tsx > ../../../../packages/component/src/components/app-sidebar/index.tsx
2) ../../../../packages/component/src/components/page-list/all-page.tsx > ../../../../packages/component/src/components/page-list/all-pages-body.tsx
3) ../../../../packages/component/src/components/page-list/all-page.tsx > ../../../../packages/component/src/components/page-list/all-pages-body.tsx > ../../../../packages/component/src/components/page-list/index.tsx
4) ../../../../packages/component/src/components/page-list/all-page.tsx > ../../../../packages/component/src/components/page-list/mobile.tsx

@codesandbox
Copy link

codesandbox bot commented May 22, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 4:51am
affine-storybook 🛑 Canceled (Inspect) May 22, 2023 4:51am

@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:30 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:30 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:31 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:31 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:31 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (752bc9c) 72.56% compared to head (2ab1a72) 72.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2475      +/-   ##
==========================================
- Coverage   72.56%   72.55%   -0.02%     
==========================================
  Files         319      318       -1     
  Lines        7036     7036              
  Branches     1147     1147              
==========================================
- Hits         5106     5105       -1     
- Misses       1728     1731       +3     
+ Partials      202      200       -2     
Flag Coverage Δ
e2etest 66.12% <100.00%> (-0.11%) ⬇️
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 47.44% <100.00%> (-0.07%) ⬇️
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-test 73.12% <ø> (ø)
storybook-test 56.57% <100.00%> (ø)
unittest 37.41% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/component/src/components/page-list/all-page.tsx 80.95% <ø> (ø)
...ponent/src/components/page-list/all-pages-body.tsx 87.50% <ø> (ø)
...ages/component/src/components/page-list/mobile.tsx 17.64% <ø> (ø)
...ges/component/src/components/app-sidebar/index.tsx 97.22% <100.00%> (+0.16%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:37 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2ab1a72
Status: ✅  Deploy successful!
Preview URL: https://6ceb8a84.affine.pages.dev
Branch Preview URL: https://circular-detect.affine.pages.dev

View logs

@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:39 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:39 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:39 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:39 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:39 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:39 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:39 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn temporarily deployed to development May 22, 2023 02:39 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 22, 2023 02:41 Inactive
@perfsee
Copy link

perfsee bot commented May 22, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …rcular-detect                 +/- ##
===================================================================
< Bundle              3.11 MB        3.31 MB     +205 kB(+6.58%)   
< Initial JS          1.86 MB        2.08 MB    +222 kB(+11.91%)   
< Initial CSS         16.8 kB        35.4 kB  +18.7 kB(+111.53%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             47                  +6   
< Chunks                   39             40                  +1   
< Packages                132            145                 +13   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …rcular-detect                 +/- ##
===================================================================
< Bundle                 3 MB        3.19 MB     +195 kB(+6.51%)   
< Initial JS          1.75 MB        1.96 MB    +212 kB(+12.13%)   
< Initial CSS         16.8 kB        35.4 kB  +18.7 kB(+111.53%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             45                  +6   
< Chunks                   37             38                  +1   
< Packages                132            145                 +13   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …rcular-detect                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 22, 2023 02:46 Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:32 — with GitHub Actions Inactive
@himself65 himself65 enabled auto-merge (squash) May 22, 2023 04:33
@himself65 himself65 temporarily deployed to development May 22, 2023 04:35 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:35 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:35 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:35 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:35 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:38 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 22, 2023 04:39 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 22, 2023 04:46 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 22, 2023 04:51 Inactive
@himself65 himself65 merged commit 2e23a48 into master May 22, 2023
9 checks passed
@himself65 himself65 deleted the circular-detect branch May 22, 2023 04:53
himself65 added a commit that referenced this pull request May 25, 2023
Co-authored-by: himself65 <himself65@outlook.com>
himself65 added a commit that referenced this pull request May 25, 2023
Co-authored-by: himself65 <himself65@outlook.com>
himself65 added a commit that referenced this pull request Jun 2, 2023
Co-authored-by: himself65 <himself65@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants