Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fav reference style issue #2476

Merged
merged 1 commit into from
May 22, 2023
Merged

fix: fav reference style issue #2476

merged 1 commit into from
May 22, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 22, 2023

No description provided.

@codesandbox
Copy link

codesandbox bot commented May 22, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@pengx17 pengx17 temporarily deployed to development May 22, 2023 02:58 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 3:07am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 3:07am

@pengx17 pengx17 temporarily deployed to development May 22, 2023 02:58 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 02:58 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 02:58 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 02:58 — with GitHub Actions Inactive
@pengx17 pengx17 requested a review from himself65 May 22, 2023 02:59
@pengx17 pengx17 temporarily deployed to development May 22, 2023 03:01 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (d68b421) 72.58% compared to head (40ffa28) 72.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2476      +/-   ##
==========================================
- Coverage   72.58%   72.55%   -0.03%     
==========================================
  Files         319      319              
  Lines        7036     7036              
  Branches     1147     1147              
==========================================
- Hits         5107     5105       -2     
- Misses       1728     1729       +1     
- Partials      201      202       +1     
Flag Coverage Δ
e2etest 66.14% <ø> (-0.13%) ⬇️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 47.44% <ø> (-0.11%) ⬇️
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
storybook-test 56.57% <ø> (ø)
unittest 37.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/workspace-slider-bar/favorite/favorite-list.tsx 95.83% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@perfsee
Copy link

perfsee bot commented May 22, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …/styles-issue                 +/- ##
===================================================================
< Bundle              3.11 MB        3.31 MB     +199 kB(+6.40%)   
< Initial JS          1.86 MB        2.08 MB    +222 kB(+11.91%)   
< Initial CSS         16.8 kB        35.4 kB  +18.7 kB(+111.48%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             47                  +6   
< Chunks                   39             40                  +1   
< Packages                132            145                 +13   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …/styles-issue                 +/- ##
===================================================================
< Bundle                 3 MB        3.19 MB     +189 kB(+6.32%)   
< Initial JS          1.75 MB        1.96 MB    +212 kB(+12.13%)   
< Initial CSS         16.8 kB        35.4 kB  +18.7 kB(+111.48%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             45                  +6   
< Chunks                   37             38                  +1   
< Packages                132            145                 +13   
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …/styles-issue                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 22, 2023 03:02 Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 03:03 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 03:03 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 03:03 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 03:03 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 03:03 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 03:03 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 03:03 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 03:03 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 40ffa28
Status: ✅  Deploy successful!
Preview URL: https://f6d80383.affine.pages.dev
Branch Preview URL: https://0522-fix-styles-issue.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 22, 2023 03:07 Inactive
@himself65 himself65 merged commit 752bc9c into master May 22, 2023
11 checks passed
@himself65 himself65 deleted the 0522/fix/styles-issue branch May 22, 2023 04:01
himself65 pushed a commit that referenced this pull request May 25, 2023
himself65 pushed a commit that referenced this pull request May 25, 2023
himself65 pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants