Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flatten i18n keys #2483

Merged
merged 2 commits into from
May 22, 2023
Merged

fix: flatten i18n keys #2483

merged 2 commits into from
May 22, 2023

Conversation

lawvs
Copy link
Member

@lawvs lawvs commented May 22, 2023

No description provided.

@codesandbox
Copy link

codesandbox bot commented May 22, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d78acc2
Status: ✅  Deploy successful!
Preview URL: https://e0d9faa8.affine.pages.dev
Branch Preview URL: https://feat-flat-i18n-key.affine.pages.dev

View logs

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 8:09am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 8:09am

@lawvs lawvs temporarily deployed to development May 22, 2023 07:51 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 22, 2023 07:51 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 22, 2023 07:51 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 22, 2023 07:51 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 22, 2023 07:51 — with GitHub Actions Inactive
@github-actions github-actions bot added the mod:i18n Related to i18n label May 22, 2023
@lawvs lawvs temporarily deployed to development May 22, 2023 07:53 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 66.15% and project coverage change: -0.15 ⚠️

Comparison is base (1f51079) 72.71% compared to head (d78acc2) 72.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2483      +/-   ##
==========================================
- Coverage   72.71%   72.56%   -0.15%     
==========================================
  Files         315      318       +3     
  Lines        7036     7047      +11     
  Branches     1149     1147       -2     
==========================================
- Hits         5116     5114       -2     
- Misses       1720     1732      +12     
- Partials      200      201       +1     
Flag Coverage Δ
e2etest 66.33% <70.73%> (-0.04%) ⬇️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 47.56% <31.70%> (+0.08%) ⬆️
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
storybook-test 56.57% <69.23%> (-0.32%) ⬇️
unittest 37.43% <28.26%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/page-list/components/new-page-buttton.tsx 72.72% <ø> (ø)
...kages/component/src/components/page-list/styles.ts 87.50% <ø> (-12.50%) ⬇️
...ages/component/src/components/page-list/mobile.tsx 17.64% <17.64%> (ø)
...c/components/page-list/components/favorite-tag.tsx 69.23% <69.23%> (ø)
...es/component/src/components/page-list/all-page.tsx 80.95% <75.00%> (+4.95%) ⬆️
...ponent/src/components/page-list/all-pages-body.tsx 87.50% <87.50%> (ø)
...ponents/blocksuite/block-suite-page-list/utils.tsx 100.00% <100.00%> (ø)
...src/components/page-list/components/title-cell.tsx 100.00% <100.00%> (ø)
packages/component/src/ui/menu/menu.tsx 57.14% <100.00%> (ø)
packages/component/src/ui/table/styles.ts 100.00% <100.00%> (ø)
... and 4 more

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 enabled auto-merge (squash) May 22, 2023 07:54
@lawvs lawvs temporarily deployed to development May 22, 2023 07:56 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 22, 2023 07:56 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 22, 2023 07:56 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 22, 2023 07:56 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 22, 2023 07:56 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 22, 2023 07:56 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 22, 2023 07:56 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development May 22, 2023 07:56 — with GitHub Actions Inactive
@lawvs lawvs requested a review from JimmFly May 22, 2023 07:58
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 22, 2023 08:04 Inactive
@himself65 himself65 merged commit fe5be0c into master May 22, 2023
8 checks passed
@himself65 himself65 deleted the feat/flat-i18n-key branch May 22, 2023 08:08
@vercel vercel bot temporarily deployed to Preview – affine-preview May 22, 2023 08:09 Inactive
himself65 pushed a commit that referenced this pull request May 25, 2023
himself65 pushed a commit that referenced this pull request May 25, 2023
himself65 pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants