Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(electron): sqlite db data workflow (remove symlink & fs watcher) #2491

Merged
merged 17 commits into from May 29, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 22, 2023

Related issues

This PR involves:

  • reorganizing handlers/events in electron. They are now categorized by feature.
  • optimized how to handle handler/event registration (exposed apis) in preload. No more magic static build static.
  • feature change on data flow
  • adopt tests (new test cases on the way)

image
image

@codesandbox
Copy link

codesandbox bot commented May 22, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2023 0:11am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2023 0:11am

@pengx17 pengx17 temporarily deployed to development May 22, 2023 16:54 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 16:54 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 16:54 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 16:54 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 22, 2023 16:54 — with GitHub Actions Inactive
@github-actions github-actions bot added app:electron Related to electron app mod:workspace Related to workspace test labels May 22, 2023
@pengx17 pengx17 temporarily deployed to development May 22, 2023 16:57 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 22, 2023 16:58 Inactive
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (e0eb216) 70.38% compared to head (a1e5ff6) 70.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2491      +/-   ##
==========================================
+ Coverage   70.38%   70.41%   +0.03%     
==========================================
  Files         321      321              
  Lines        7396     7390       -6     
  Branches     1230     1228       -2     
==========================================
- Hits         5206     5204       -2     
+ Misses       1986     1985       -1     
+ Partials      204      201       -3     
Flag Coverage Δ
e2etest 65.38% <26.66%> (+0.13%) ⬆️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 46.63% <80.00%> (-0.09%) ⬇️
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
storybook-test 49.97% <ø> (ø)
unittest 36.41% <26.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/component/src/components/page-list/all-page.tsx 79.16% <ø> (ø)
...e/workspace-setting-detail/panel/general/index.tsx 73.07% <100.00%> (ø)
packages/workspace/src/blob/sqlite-blob-storage.ts 90.00% <100.00%> (ø)
packages/workspace/src/providers/index.ts 83.96% <100.00%> (+0.92%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a1e5ff6
Status: ✅  Deploy successful!
Preview URL: https://25ccfc31.affine.pages.dev
Branch Preview URL: https://xp-0523-refactor-db-data-pat.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-preview May 22, 2023 17:02 Inactive
@pengx17 pengx17 temporarily deployed to development May 23, 2023 08:30 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 23, 2023 08:30 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 23, 2023 08:30 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 23, 2023 08:30 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 23, 2023 08:30 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 23, 2023 08:33 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 23, 2023 08:34 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 23, 2023 08:39 Inactive
@pengx17 pengx17 temporarily deployed to development May 23, 2023 09:57 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 23, 2023 09:57 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 23, 2023 09:57 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 28, 2023 10:35 Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:01 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:01 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:01 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:01 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:01 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:04 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 28, 2023 12:06 Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:07 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:07 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:07 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:07 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:07 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:07 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:07 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development May 28, 2023 12:07 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 28, 2023 12:11 Inactive
@pengx17 pengx17 marked this pull request as ready for review May 28, 2023 12:22
@himself65 himself65 merged commit 20cf452 into master May 29, 2023
12 checks passed
@himself65 himself65 deleted the xp/0523/refactor/db-data-pattern branch May 29, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app app:web mod:component mod:workspace Related to workspace
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants