Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use react-resizable-panels #2679

Merged
merged 2 commits into from Jun 4, 2023
Merged

fix: use react-resizable-panels #2679

merged 2 commits into from Jun 4, 2023

Conversation

himself65
Copy link
Contributor

No description provided.

@codesandbox
Copy link

codesandbox bot commented Jun 4, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@himself65 himself65 temporarily deployed to development June 4, 2023 15:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:10 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Jun 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview 🛑 Canceled (Inspect) Jun 4, 2023 3:24pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2023 3:24pm

@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Patch coverage: 36.36% and project coverage change: -1.72 ⚠️

Comparison is base (acda594) 68.99% compared to head (e998218) 67.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2679      +/-   ##
==========================================
- Coverage   68.99%   67.28%   -1.72%     
==========================================
  Files         338      337       -1     
  Lines        7683     7653      -30     
  Branches     1241     1234       -7     
==========================================
- Hits         5301     5149     -152     
- Misses       2119     2236     +117     
- Partials      263      268       +5     
Flag Coverage Δ
e2etest 62.33% <36.36%> (-0.04%) ⬇️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 ?
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
storybook-test 52.89% <ø> (ø)
unittest 51.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/web/src/pages/_app.tsx 64.28% <ø> (ø)
plugins/copilot/src/UI/header-item.tsx 42.85% <ø> (ø)
apps/web/src/components/page-detail-editor.tsx 74.50% <36.36%> (+11.79%) ⬆️

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development June 4, 2023 15:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:14 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e998218
Status: ✅  Deploy successful!
Preview URL: https://ed670d74.affine.pages.dev
Branch Preview URL: https://himself65-0604-fix.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-storybook June 4, 2023 15:19 Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:20 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented Jun 4, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …lf65/0604-fix                 +/- ##
===================================================================
> Bundle              4.19 MB        4.03 MB     -160 kB(-3.81%)   
< Initial JS          2.17 MB        2.18 MB    +15.6 kB(+0.72%)   
> Initial CSS         80.2 kB        67.6 kB   -12.5 kB(-15.62%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   73             73                       
= Chunks                   56             56                       
> Packages                203            187                 -16   
= Duplicates               14             14                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …lf65/0604-fix                 +/- ##
===================================================================
> Bundle              4.07 MB        3.91 MB     -160 kB(-3.93%)   
< Initial JS          2.05 MB        2.06 MB    +15.6 kB(+0.76%)   
> Initial CSS         80.2 kB        67.6 kB   -12.5 kB(-15.62%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   71             71                       
= Chunks                   54             54                       
> Packages                203            187                 -16   
= Duplicates               14             14                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …lf65/0604-fix                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview June 4, 2023 15:24 Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 4, 2023 15:25 — with GitHub Actions Inactive
@himself65 himself65 merged commit 1716e7a into master Jun 4, 2023
9 checks passed
@himself65 himself65 deleted the himself65/0604-fix branch June 4, 2023 15:33
himself65 added a commit that referenced this pull request Jun 8, 2023
(cherry picked from commit 1716e7a)
himself65 added a commit that referenced this pull request Jun 15, 2023
(cherry picked from commit 1716e7a)
himself65 added a commit that referenced this pull request Jun 16, 2023
(cherry picked from commit 1716e7a)
himself65 added a commit that referenced this pull request Jun 20, 2023
(cherry picked from commit 1716e7a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant