Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import workspace may only show default preload page #2685

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jun 5, 2023

fix #2671

Thanks for @thorseraq for helping me debug the issue.
The steps in the red area should be skipped for adding workspace.
image

@codesandbox
Copy link

codesandbox bot commented Jun 5, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:12 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 6:01am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 6:01am

@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:12 — with GitHub Actions Inactive
@github-actions github-actions bot added app:web mod:workspace Related to workspace labels Jun 5, 2023
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:15 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 79.24% and project coverage change: +0.22 🎉

Comparison is base (3b4cfc6) 69.11% compared to head (043521f) 69.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2685      +/-   ##
==========================================
+ Coverage   69.11%   69.34%   +0.22%     
==========================================
  Files         339      339              
  Lines        7678     7708      +30     
  Branches     1240     1244       +4     
==========================================
+ Hits         5307     5345      +38     
+ Misses       2107     2098       -9     
- Partials      264      265       +1     
Flag Coverage Δ
e2etest 63.74% <9.43%> (+0.12%) ⬆️
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 46.53% <73.58%> (+1.43%) ⬆️
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-test 73.12% <ø> (ø)
storybook-test 52.52% <ø> (ø)
unittest 51.38% <73.58%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/workspace/src/type.ts 100.00% <ø> (ø)
packages/workspace/src/providers/index.ts 81.20% <79.24%> (-3.35%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:17 — with GitHub Actions Inactive
@pengx17 pengx17 changed the title fix: import workspace fix: import workspace may only show default preload page Jun 5, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 043521f
Status: ✅  Deploy successful!
Preview URL: https://266cb25c.affine.pages.dev
Branch Preview URL: https://xp-0605-fix-import-workspace.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-storybook June 5, 2023 09:24 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview June 5, 2023 09:28 Inactive
@perfsee
Copy link

perfsee bot commented Jun 5, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …ort-workspace                 +/- ##
===================================================================
> Bundle              4.04 MB        4.04 MB       -90 B(-0.00%)   
< Initial JS          2.18 MB        2.18 MB       +82 B(+0.00%)   
> Initial CSS         67.8 kB        67.7 kB      -172 B(-0.25%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   73             73                       
= Chunks                   56             56                       
= Packages                187            187                       
= Duplicates               14             14                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …ort-workspace                 +/- ##
===================================================================
> Bundle              3.91 MB        3.91 MB       -90 B(-0.00%)   
< Initial JS          2.06 MB        2.06 MB       +82 B(+0.00%)   
> Initial CSS         67.8 kB        67.7 kB      -172 B(-0.25%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   71             71                       
= Chunks                   54             54                       
= Packages                187            187                       
= Duplicates               14             14                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …ort-workspace                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:31 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:31 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:31 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 5, 2023 09:31 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:19 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:19 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:19 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:19 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook June 6, 2023 05:21 Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:54 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview June 6, 2023 05:56 Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 6, 2023 05:59 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook June 6, 2023 06:01 Inactive
@pengx17 pengx17 requested a review from himself65 June 6, 2023 06:38
@himself65 himself65 merged commit 84f68fc into master Jun 6, 2023
9 checks passed
@himself65 himself65 deleted the xp/0605/fix-import-workspace branch June 6, 2023 06:42
himself65 pushed a commit that referenced this pull request Jun 8, 2023
himself65 pushed a commit that referenced this pull request Jun 15, 2023
himself65 pushed a commit that referenced this pull request Jun 16, 2023
himself65 pushed a commit that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:workspace Related to workspace
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

add workspace may not be able to load DB correctly​
2 participants