-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import workspace may only show default preload page #2685
Conversation
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2685 +/- ##
==========================================
+ Coverage 69.11% 69.34% +0.22%
==========================================
Files 339 339
Lines 7678 7708 +30
Branches 1240 1244 +4
==========================================
+ Hits 5307 5345 +38
+ Misses 2107 2098 -9
- Partials 264 265 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Deploying with
|
Latest commit: |
043521f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://266cb25c.affine.pages.dev |
Branch Preview URL: | https://xp-0605-fix-import-workspace.affine.pages.dev |
affine-toeverythingBundle maindiff ------------------- Bundle Size Diff -------------------------
@@ EntryPoint: main @@
## master …ort-workspace +/- ##
===================================================================
> Bundle 4.04 MB 4.04 MB -90 B(-0.00%)
< Initial JS 2.18 MB 2.18 MB +82 B(+0.00%)
> Initial CSS 67.8 kB 67.7 kB -172 B(-0.25%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 73 73
= Chunks 56 56
= Packages 187 187
= Duplicates 14 14
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries
! Separate mixed content assets files
! Avoid cache wasting
@@ EntryPoint: pages/_app @@
## master …ort-workspace +/- ##
===================================================================
> Bundle 3.91 MB 3.91 MB -90 B(-0.00%)
< Initial JS 2.06 MB 2.06 MB +82 B(+0.00%)
> Initial CSS 67.8 kB 67.7 kB -172 B(-0.25%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 71 71
= Chunks 54 54
= Packages 187 187
= Duplicates 14 14
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries
! Separate mixed content assets files
! Avoid cache wasting
@@ EntryPoint: pages/_error @@
## master …ort-workspace +/- ##
===================================================================
= Bundle 16.6 kB 16.6 kB
= Initial JS 16.6 kB 16.6 kB
= Initial CSS 0 B 0 B
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 2 2
= Chunks 2 2
= Packages 5 5
= Duplicates 0 0
...and more |
(cherry picked from commit 84f68fc)
(cherry picked from commit 84f68fc)
(cherry picked from commit 84f68fc)
(cherry picked from commit 84f68fc)
fix #2671
Thanks for @thorseraq for helping me debug the issue.
![image](https://private-user-images.githubusercontent.com/584378/243312644-94185daf-d720-40b0-844a-041560a97d85.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzYyOTYsIm5iZiI6MTcyMTEzNTk5NiwicGF0aCI6Ii81ODQzNzgvMjQzMzEyNjQ0LTk0MTg1ZGFmLWQ3MjAtNDBiMC04NDRhLTA0MTU2MGE5N2Q4NS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxNlQxMzE5NTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mZjcxOTYwMWM0NjFjOTBjZGZlNzA0OTI3NTNkODZiMzY1MWUxYjhhNjljZGViY2I5NDlkODJmZTA4YzkxODFhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.ZotvaPoL13iecz2zYHfHTtSnPG4ovFkB7lrgMuORyT8)
The steps in the red area should be skipped for adding workspace.