Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update desc for empty page #2710

Merged
merged 2 commits into from
Jun 8, 2023
Merged

feat: update desc for empty page #2710

merged 2 commits into from
Jun 8, 2023

Conversation

lawvs
Copy link
Member

@lawvs lawvs commented Jun 7, 2023

Fix #2666

Screenshot 2023-06-07 at 5 29 16 PM

@lawvs lawvs requested a review from JimmFly as a code owner June 7, 2023 09:28
@codesandbox
Copy link

codesandbox bot commented Jun 7, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Jun 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 0:09am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 0:09am

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 7, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bb8ee79
Status: ✅  Deploy successful!
Preview URL: https://e2195b0b.affine.pages.dev
Branch Preview URL: https://chore-empty-desc-update.affine.pages.dev

View logs

@lawvs lawvs temporarily deployed to development June 7, 2023 09:30 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 7, 2023 09:30 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 7, 2023 09:30 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 7, 2023 09:30 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 7, 2023 09:30 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 7, 2023 09:32 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 55.55% and project coverage change: -0.03 ⚠️

Comparison is base (6f411bd) 69.96% compared to head (bb8ee79) 69.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2710      +/-   ##
==========================================
- Coverage   69.96%   69.93%   -0.03%     
==========================================
  Files         340      340              
  Lines        7228     7235       +7     
  Branches     1021     1025       +4     
==========================================
+ Hits         5057     5060       +3     
- Misses       1869     1873       +4     
  Partials      302      302              
Flag Coverage Δ
e2etest 63.25% <62.50%> (-0.02%) ⬇️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 45.46% <0.00%> (-0.07%) ⬇️
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
unittest 50.87% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/blocksuite/block-suite-page-list/index.tsx 66.66% <50.00%> (-2.46%) ⬇️
packages/component/src/ui/empty/empty.tsx 80.00% <66.66%> (-20.00%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lawvs lawvs temporarily deployed to development June 7, 2023 09:34 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 7, 2023 09:34 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 7, 2023 09:34 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 7, 2023 09:34 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 7, 2023 09:34 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 7, 2023 09:34 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 7, 2023 09:34 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 7, 2023 09:34 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook June 7, 2023 09:58 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview June 7, 2023 10:02 Inactive
@perfsee
Copy link

perfsee bot commented Jun 7, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …y-desc-update                 +/- ##
===================================================================
< Bundle              4.43 MB        4.44 MB    +3.95 kB(+0.09%)   
< Initial JS          2.33 MB        2.33 MB    +1.99 kB(+0.09%)   
< Initial CSS          117 kB         117 kB      +566 B(+0.49%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   78             78                       
= Chunks                   61             61                       
= Packages                195            195                       
= Duplicates               15             15                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …y-desc-update                 +/- ##
===================================================================
< Bundle              4.31 MB        4.31 MB    +3.95 kB(+0.09%)   
< Initial JS          2.21 MB        2.21 MB    +1.99 kB(+0.09%)   
< Initial CSS          117 kB         117 kB      +566 B(+0.49%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   76             76                       
= Chunks                   59             59                       
= Packages                195            195                       
= Duplicates               15             15                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …y-desc-update                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@lawvs lawvs temporarily deployed to development June 8, 2023 05:39 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 05:39 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 05:39 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 06:22 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 06:22 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview June 8, 2023 06:26 Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:00 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:00 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:00 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:00 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:00 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:03 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview June 8, 2023 12:05 Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:08 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:08 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:08 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:08 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:08 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:08 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:08 — with GitHub Actions Inactive
@lawvs lawvs temporarily deployed to development June 8, 2023 12:08 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook June 8, 2023 12:09 Inactive
@himself65 himself65 merged commit ec99a0c into master Jun 8, 2023
10 checks passed
@himself65 himself65 deleted the chore/empty-desc-update branch June 8, 2023 12:28
himself65 pushed a commit that referenced this pull request Jun 9, 2023
himself65 pushed a commit that referenced this pull request Jun 15, 2023
himself65 pushed a commit that referenced this pull request Jun 16, 2023
himself65 pushed a commit that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Optimization of the blank page sentence for "All pages"
3 participants