Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enhance tsconfig type check #2732

Merged
merged 8 commits into from
Jun 8, 2023
Merged

build: enhance tsconfig type check #2732

merged 8 commits into from
Jun 8, 2023

Conversation

himself65
Copy link
Contributor

No description provided.

@codesandbox
Copy link

codesandbox bot commented Jun 8, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Jun 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 5:36pm
affine-storybook 🛑 Canceled (Inspect) Jun 8, 2023 5:36pm

@himself65 himself65 temporarily deployed to development June 8, 2023 12:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 12:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 12:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 12:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 12:06 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f5c648c
Status: ✅  Deploy successful!
Preview URL: https://b2024074.affine.pages.dev
Branch Preview URL: https://himself65-type-check.affine.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 52.17% and project coverage change: -1.98 ⚠️

Comparison is base (fc9a9f4) 69.81% compared to head (f5c648c) 67.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2732      +/-   ##
==========================================
- Coverage   69.81%   67.83%   -1.98%     
==========================================
  Files         339      337       -2     
  Lines        7221     7194      -27     
  Branches     1020     1014       -6     
==========================================
- Hits         5041     4880     -161     
- Misses       1875     2003     +128     
- Partials      305      311       +6     
Flag Coverage Δ
e2etest 63.03% <21.42%> (-0.11%) ⬇️
e2etest-ubuntu-latest-x64 ?
e2etest-windows-latest-x64 ?
server-test 72.91% <100.00%> (-0.21%) ⬇️
unittest 50.30% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/blocksuite/block-suite-page-list/index.tsx 65.75% <0.00%> (-0.92%) ⬇️
...nent/src/components/app-sidebar/spolight/index.tsx 92.30% <0.00%> (-3.70%) ⬇️
...ponent/src/components/block-suite-editor/index.tsx 76.56% <0.00%> (-1.22%) ⬇️
.../src/components/image-preview-modal/index.jotai.ts 66.66% <0.00%> (-8.34%) ⬇️
packages/component/src/ui/tree-view/utils.ts 0.00% <0.00%> (ø)
.../hooks/src/use-block-suite-workspace-avatar-url.ts 84.00% <0.00%> (-3.50%) ⬇️
packages/i18n/src/index.ts 70.96% <0.00%> (-2.37%) ⬇️
packages/workspace/src/affine/login.ts 51.76% <0.00%> (-0.62%) ⬇️
packages/workspace/src/atom.ts 80.00% <0.00%> (-4.85%) ⬇️
packages/workspace/src/utils.ts 58.33% <ø> (-5.56%) ⬇️
... and 9 more

... and 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development June 8, 2023 12:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 12:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 12:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 12:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 12:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 12:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 12:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:21 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:21 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:21 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:21 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:21 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:27 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook June 8, 2023 17:31 Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:32 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development June 8, 2023 17:32 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview June 8, 2023 17:35 Inactive
@himself65 himself65 merged commit b383ce3 into master Jun 8, 2023
10 checks passed
@himself65 himself65 deleted the himself65/type-check branch June 8, 2023 17:43
himself65 added a commit that referenced this pull request Jun 9, 2023
himself65 added a commit that referenced this pull request Jun 15, 2023
himself65 added a commit that referenced this pull request Jun 16, 2023
himself65 added a commit that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant