Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: potential flaky issues #2733

Merged
merged 1 commit into from
Jun 8, 2023
Merged

fix: potential flaky issues #2733

merged 1 commit into from
Jun 8, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jun 8, 2023

No description provided.

@codesandbox
Copy link

codesandbox bot commented Jun 8, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:35 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Jun 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 3:28pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 3:28pm

@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:35 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:35 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:35 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:35 — with GitHub Actions Inactive
@github-actions github-actions bot added the app:electron Related to electron app label Jun 8, 2023
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:38 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:40 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (ec99a0c) 69.93% compared to head (9a204e0) 69.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2733      +/-   ##
==========================================
- Coverage   69.93%   69.89%   -0.05%     
==========================================
  Files         340      340              
  Lines        7235     7235              
  Branches     1025     1025              
==========================================
- Hits         5060     5057       -3     
- Misses       1871     1875       +4     
+ Partials      304      303       -1     
Flag Coverage Δ
e2etest 63.18% <ø> (-0.09%) ⬇️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 45.48% <ø> (ø)
e2etest-windows-latest-x64 ?
server-test 73.12% <ø> (ø)
unittest 50.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a204e0
Status: ✅  Deploy successful!
Preview URL: https://eb8460c8.affine.pages.dev
Branch Preview URL: https://xp-0608-fix-flaky.affine.pages.dev

View logs

@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 14:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:03 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview June 8, 2023 15:03 Inactive
@perfsee
Copy link

perfsee bot commented Jun 8, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …608/fix/flaky                 +/- ##
===================================================================
= Bundle              4.44 MB        4.44 MB                       
= Initial JS          2.33 MB        2.33 MB                       
= Initial CSS          117 kB         117 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   78             78                       
= Chunks                   61             61                       
= Packages                195            195                       
= Duplicates               15             15                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        

@@                    EntryPoint: pages/_app                     @@
##                     master …608/fix/flaky                 +/- ##
===================================================================
= Bundle              4.31 MB        4.31 MB                       
= Initial JS          2.21 MB        2.21 MB                       
= Initial CSS          117 kB         117 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   76             76                       
= Chunks                   59             59                       
= Packages                195            195                       
= Duplicates               15             15                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        

@@                   EntryPoint: pages/_error                    @@
##                     master …608/fix/flaky                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:06 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:07 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:07 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:07 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:07 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook June 8, 2023 15:08 Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:20 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:20 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:20 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:20 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:20 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:22 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook June 8, 2023 15:24 Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:27 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development June 8, 2023 15:27 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview June 8, 2023 15:28 Inactive
@himself65 himself65 merged commit 935b4f8 into master Jun 8, 2023
9 checks passed
@himself65 himself65 deleted the xp/0608/fix/flaky branch June 8, 2023 16:20
himself65 pushed a commit that referenced this pull request Jun 9, 2023
(cherry picked from commit 935b4f8)
himself65 pushed a commit that referenced this pull request Jun 15, 2023
(cherry picked from commit 935b4f8)
himself65 pushed a commit that referenced this pull request Jun 16, 2023
(cherry picked from commit 935b4f8)
himself65 pushed a commit that referenced this pull request Jun 20, 2023
(cherry picked from commit 935b4f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants