New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add prompt select_account for google login #4415
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1747b2d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4415 +/- ##
==========================================
- Coverage 72.67% 72.67% -0.01%
==========================================
Files 402 402
Lines 13508 13511 +3
Branches 1312 1312
==========================================
+ Hits 9817 9819 +2
- Misses 3352 3353 +1
Partials 339 339
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Deploying with Cloudflare Pages
|
@pengx17 have you tested it? |
I was not be able to reproduce the issue but just checked the new URL requested to Google You can see Before the change, the auth url is |
https://developers.google.com/identity/openid-connect/openid-connect#authenticationuriparameters:~:text=to%20the%20client.-,select_account,-The%20authorization%20server
I am not sure but it looks like I always got the account selection prompted every time I signin with google oauth. It may help to explicitly show account selection for some users.