Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add prompt select_account for google login #4415

Merged
merged 1 commit into from Sep 20, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Sep 19, 2023

https://developers.google.com/identity/openid-connect/openid-connect#authenticationuriparameters:~:text=to%20the%20client.-,select_account,-The%20authorization%20server

I am not sure but it looks like I always got the account selection prompted every time I signin with google oauth. It may help to explicitly show account selection for some users.

@codesandbox
Copy link

codesandbox bot commented Sep 19, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:17 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
affine-dev-docs ⬜️ Ignored (Inspect) Sep 19, 2023 5:17am
affine-prod-temp ⬜️ Ignored (Inspect) Sep 19, 2023 5:17am

@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:17 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:18 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:18 — with GitHub Actions Inactive
@nx-cloud
Copy link

nx-cloud bot commented Sep 19, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1747b2d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (f395a95) 72.67% compared to head (1747b2d) 72.67%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4415      +/-   ##
==========================================
- Coverage   72.67%   72.67%   -0.01%     
==========================================
  Files         402      402              
  Lines       13508    13511       +3     
  Branches     1312     1312              
==========================================
+ Hits         9817     9819       +2     
- Misses       3352     3353       +1     
  Partials      339      339              
Flag Coverage Δ
e2e-plugin-test 35.57% <ø> (+0.09%) ⬆️
e2etest 56.82% <ø> (+0.03%) ⬆️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 44.55% <ø> (ø)
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-e2etest 56.23% <ø> (+0.03%) ⬆️
server-test 77.01% <0.00%> (-0.04%) ⬇️
unittest 52.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
apps/server/src/modules/auth/next-auth-options.ts 50.43% <0.00%> (-0.67%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1747b2d
Status: ✅  Deploy successful!
Preview URL: https://00f72227.affine-dev.pages.dev
Branch Preview URL: https://xp-fix-0919-google-oauth-sel.affine-dev.pages.dev

View logs

@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:20 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:22 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:22 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:25 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 19, 2023 05:26 — with GitHub Actions Inactive
@Brooooooklyn
Copy link
Member

@pengx17 have you tested it?

@pengx17 pengx17 temporarily deployed to development September 20, 2023 02:06 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 20, 2023 02:06 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 20, 2023 02:06 — with GitHub Actions Inactive
@Brooooooklyn Brooooooklyn added this pull request to the merge queue Sep 20, 2023
Merged via the queue into master with commit 6e79858 Sep 20, 2023
20 of 24 checks passed
@Brooooooklyn Brooooooklyn deleted the xp/fix/0919/google-oauth-select-account branch September 20, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants