Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove plugins settings #5337

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Dec 19, 2023

depend on #5324

Copy link

graphite-app bot commented Dec 19, 2023

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Dec 19, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (555d40c) 59.56% compared to head (972de52) 59.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5337   +/-   ##
=======================================
  Coverage   59.56%   59.56%           
=======================================
  Files         512      512           
  Lines       22207    22207           
  Branches     1981     1981           
=======================================
  Hits        13227    13227           
  Misses       8639     8639           
  Partials      341      341           
Flag Coverage Δ
e2e-plugin-test 39.77% <ø> (ø)
server-test 69.61% <ø> (ø)
unittest 54.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 12-19-fix_core_remove_plugins_settings branch from 634295b to be08009 Compare December 25, 2023 02:30
@pengx17 pengx17 changed the base branch from 12-19-fix_core_remove_WorkspaceAdapter_related_code to canary December 25, 2023 02:30
@pengx17 pengx17 marked this pull request as draft December 25, 2023 02:45
@pengx17 pengx17 force-pushed the 12-19-fix_core_remove_plugins_settings branch 3 times, most recently from 8104e57 to f3a9c44 Compare December 26, 2023 03:48
@pengx17 pengx17 marked this pull request as ready for review December 26, 2023 06:10
@pengx17 pengx17 force-pushed the 12-19-fix_core_remove_plugins_settings branch from f3a9c44 to 7ccc130 Compare December 26, 2023 06:11
@github-actions github-actions bot added mod:component test Related to test cases labels Dec 26, 2023
Copy link

graphite-app bot commented Dec 26, 2023

Merge activity

@pengx17 pengx17 force-pushed the 12-19-fix_core_remove_plugins_settings branch from 7ccc130 to 972de52 Compare December 26, 2023 06:22
@graphite-app graphite-app bot merged commit 972de52 into canary Dec 26, 2023
33 of 34 checks passed
@graphite-app graphite-app bot deleted the 12-19-fix_core_remove_plugins_settings branch December 26, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants