Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove adapter #5324

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 18, 2023

workspace adapter is no longer used.

Copy link

graphite-app bot commented Dec 18, 2023

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05025bf) 59.56% compared to head (e1bd13a) 59.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5324      +/-   ##
==========================================
- Coverage   59.56%   59.55%   -0.02%     
==========================================
  Files         517      512       -5     
  Lines       22221    22193      -28     
  Branches     1979     1977       -2     
==========================================
- Hits        13237    13218      -19     
+ Misses       8642     8634       -8     
+ Partials      342      341       -1     
Flag Coverage Δ
e2e-plugin-test 39.74% <100.00%> (-0.09%) ⬇️
server-test 69.61% <ø> (ø)
unittest 54.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/refactor/remove-adapter branch from 87e98a3 to b48dac0 Compare December 18, 2023 12:53
@EYHN EYHN changed the base branch from canary to eyhn/refactor/remove/outline-plugin December 19, 2023 02:59
@EYHN EYHN force-pushed the eyhn/refactor/remove-adapter branch from b48dac0 to 3549261 Compare December 19, 2023 02:59
@github-actions github-actions bot added mod:infra Environment related issues and discussions docs Improvements or additions to documentation app:electron Related to electron app test Related to test cases mod:plugin labels Dec 19, 2023
@EYHN EYHN force-pushed the eyhn/refactor/remove-adapter branch from 3549261 to 84078be Compare December 19, 2023 08:39
@EYHN EYHN force-pushed the eyhn/refactor/remove/outline-plugin branch from 7221f5b to 63786e3 Compare December 19, 2023 09:12
@EYHN EYHN force-pushed the eyhn/refactor/remove-adapter branch from 84078be to 50fe030 Compare December 19, 2023 09:12
@EYHN EYHN force-pushed the eyhn/refactor/remove/outline-plugin branch 2 times, most recently from 3de577d to e1eca53 Compare December 20, 2023 04:56
@EYHN EYHN force-pushed the eyhn/refactor/remove-adapter branch from 50fe030 to 1bedbf9 Compare December 20, 2023 04:56
@EYHN EYHN force-pushed the eyhn/refactor/remove/outline-plugin branch from e1eca53 to 31129d0 Compare December 21, 2023 03:15
@EYHN EYHN force-pushed the eyhn/refactor/remove-adapter branch from 1bedbf9 to 6a221e8 Compare December 21, 2023 03:15
Copy link

graphite-app bot commented Dec 25, 2023

Merge activity

@EYHN EYHN force-pushed the eyhn/refactor/remove/outline-plugin branch from 31129d0 to 05025bf Compare December 25, 2023 03:24
EYHN added a commit that referenced this pull request Dec 25, 2023
workspace adapter is no longer used.
@EYHN EYHN force-pushed the eyhn/refactor/remove-adapter branch from 6a221e8 to 170bfab Compare December 25, 2023 03:25
@EYHN EYHN changed the base branch from eyhn/refactor/remove/outline-plugin to canary December 25, 2023 03:33
workspace adapter is no longer used.
@EYHN EYHN force-pushed the eyhn/refactor/remove-adapter branch from 170bfab to e1bd13a Compare December 25, 2023 03:34
@graphite-app graphite-app bot merged commit e1bd13a into canary Dec 25, 2023
37 checks passed
@graphite-app graphite-app bot deleted the eyhn/refactor/remove-adapter branch December 25, 2023 03:43
pengx17 added a commit that referenced this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app docs Improvements or additions to documentation mod:env mod:infra Environment related issues and discussions mod:plugin test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants