feat(infra): page infra #5618

EYHN · 2024-01-17T17:06:57Z

No description provided.

graphite-app · 2024-01-17T17:07:05Z

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

EYHN · 2024-01-17T17:07:09Z

Current dependencies on/for this PR:

canary
- PR feat(infra): livedata #5562
  - PR chore: support compile decorator #5595
  - PR feat(infra): di container #5497
    - PR feat(infra): standard storage service #5563
      - PR feat(infra): standard lifecycle service #5564
        
        PR chore: fix vitest error on tinykeys #5693
        
        PR feat(infra): new workspace infra #5617
        
        PR feat(infra): page infra #5618 👈
        
        PR refactor(infra): migrate to new infra #5565

This stack of pull requests is managed by Graphite.

codecov · 2024-01-17T17:58:03Z

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (2e71c98) 64.26% compared to head (1e3499c) 64.30%.

Files	Patch %	Lines
packages/common/infra/src/page/manager.ts	0.00%	14 Missing ⚠️
packages/common/infra/src/page/page.ts	0.00%	4 Missing ⚠️
packages/common/infra/src/page/context.ts	66.66%	1 Missing ⚠️
packages/common/infra/src/page/list.ts	85.71%	1 Missing ⚠️

Additional details and impacted files

@@                     Coverage Diff                      @@
##           eyhn/new-workspace-infra    #5618      +/-   ##
============================================================
+ Coverage                     64.26%   64.30%   +0.04%     
============================================================
  Files                           337      343       +6     
  Lines                         19542    19574      +32     
  Branches                       1676     1679       +3     
============================================================
+ Hits                          12558    12588      +30     
- Misses                         6756     6758       +2     
  Partials                        228      228

Flag	Coverage Δ
server-test	`70.91% <ø> (+0.12%)`	⬆️
unittest	`46.44% <37.50%> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

graphite-app · 2024-01-30T06:30:19Z

Merge activity

Jan 30, 1:30 AM: @EYHN added this pull request to the Graphite merge queue.
Jan 30, 1:46 AM: @EYHN merged this pull request with the Graphite merge queue.

This was referenced Jan 17, 2024

feat(infra): livedata #5562

Merged

chore: support compile decorator #5595

Closed

feat(infra): di container #5497

Merged

This was referenced Jan 17, 2024

feat(infra): standard lifecycle service #5564

Merged

feat(infra): standard storage service #5563

Merged

refactor(infra): migrate to new infra #5565

Merged

feat(infra): new workspace infra #5617

Merged

github-actions bot assigned EYHN Jan 17, 2024

github-actions bot added mod:infra Environment related issues and discussions test Related to test cases labels Jan 17, 2024

EYHN force-pushed the eyhn/new-workspace-infra branch from fa9fe77 to 155605a Compare January 17, 2024 17:12

EYHN force-pushed the eyhn/new-page-infra branch from 406d36c to 6542e7a Compare January 17, 2024 17:12

EYHN force-pushed the eyhn/new-workspace-infra branch from 155605a to c4dbdf7 Compare January 17, 2024 17:48

EYHN force-pushed the eyhn/new-page-infra branch from 6542e7a to f365e89 Compare January 17, 2024 17:48

EYHN force-pushed the eyhn/new-workspace-infra branch from c4dbdf7 to fefab51 Compare January 19, 2024 06:20

EYHN force-pushed the eyhn/new-page-infra branch from f365e89 to c20536e Compare January 19, 2024 06:20

EYHN force-pushed the eyhn/new-workspace-infra branch from fefab51 to ea61059 Compare January 19, 2024 06:22

EYHN force-pushed the eyhn/new-page-infra branch from c20536e to 799e5aa Compare January 19, 2024 06:22

EYHN force-pushed the eyhn/new-workspace-infra branch from ea61059 to 8b77300 Compare January 19, 2024 06:37

EYHN force-pushed the eyhn/new-page-infra branch from 799e5aa to 47c3c64 Compare January 19, 2024 06:37

EYHN force-pushed the eyhn/new-workspace-infra branch from 8b77300 to 597daf0 Compare January 19, 2024 06:39

EYHN force-pushed the eyhn/new-page-infra branch from 47c3c64 to 11ea50d Compare January 19, 2024 06:39

EYHN force-pushed the eyhn/new-workspace-infra branch from 597daf0 to 1b21c01 Compare January 19, 2024 06:45

EYHN force-pushed the eyhn/new-page-infra branch from 11ea50d to a3b6850 Compare January 19, 2024 06:45

EYHN force-pushed the eyhn/new-workspace-infra branch from 1b21c01 to 76eb4b4 Compare January 19, 2024 06:52

EYHN force-pushed the eyhn/new-page-infra branch from a3b6850 to 2602d6f Compare January 19, 2024 06:52

EYHN force-pushed the eyhn/new-workspace-infra branch from 76eb4b4 to a05e611 Compare January 22, 2024 04:18

EYHN force-pushed the eyhn/new-page-infra branch from 2602d6f to 2809d28 Compare January 22, 2024 04:18

EYHN force-pushed the eyhn/new-workspace-infra branch from a05e611 to f2b43a0 Compare January 23, 2024 16:24

EYHN force-pushed the eyhn/new-page-infra branch from 2809d28 to 1e9ed0b Compare January 23, 2024 16:24

pengx17 approved these changes Jan 24, 2024

View reviewed changes

EYHN force-pushed the eyhn/new-workspace-infra branch from f2b43a0 to 69c4408 Compare January 24, 2024 17:00

EYHN force-pushed the eyhn/new-page-infra branch from 1e9ed0b to af36595 Compare January 24, 2024 17:00

EYHN force-pushed the eyhn/new-workspace-infra branch from 69c4408 to cdb80ae Compare January 24, 2024 17:51

EYHN force-pushed the eyhn/new-page-infra branch from af36595 to f6be3d3 Compare January 24, 2024 17:51

EYHN force-pushed the eyhn/new-workspace-infra branch from cdb80ae to 6d3946e Compare January 25, 2024 03:08

EYHN force-pushed the eyhn/new-page-infra branch from f6be3d3 to ad3e489 Compare January 25, 2024 03:08

EYHN changed the base branch from eyhn/new-workspace-infra to eyhn/fix-vitest January 25, 2024 03:08

EYHN mentioned this pull request Jan 25, 2024

chore: fix vitest error on tinykeys #5693

Merged

EYHN force-pushed the eyhn/fix-vitest branch from 78dfe24 to ffb2a35 Compare January 25, 2024 03:59

EYHN force-pushed the eyhn/new-page-infra branch from ad3e489 to ac9e315 Compare January 25, 2024 03:59

EYHN changed the base branch from eyhn/fix-vitest to eyhn/new-workspace-infra January 25, 2024 03:59

Brooooooklyn approved these changes Jan 26, 2024

View reviewed changes

EYHN force-pushed the eyhn/new-workspace-infra branch from 2b5b087 to 86744a3 Compare January 26, 2024 07:27

EYHN force-pushed the eyhn/new-page-infra branch from ac9e315 to a7f462f Compare January 26, 2024 07:27

EYHN force-pushed the eyhn/new-workspace-infra branch from 86744a3 to 9733d86 Compare January 26, 2024 08:15

EYHN force-pushed the eyhn/new-page-infra branch from a7f462f to fac15e1 Compare January 26, 2024 08:15

EYHN force-pushed the eyhn/new-workspace-infra branch from 9733d86 to 90bdd03 Compare January 30, 2024 05:47

EYHN force-pushed the eyhn/new-page-infra branch from fac15e1 to b081adc Compare January 30, 2024 05:47

feat(infra): page infra (#5618)

1e3499c

EYHN force-pushed the eyhn/new-workspace-infra branch from 90bdd03 to 2e71c98 Compare January 30, 2024 06:34

EYHN force-pushed the eyhn/new-page-infra branch from b081adc to 1e3499c Compare January 30, 2024 06:35

EYHN changed the base branch from eyhn/new-workspace-infra to canary January 30, 2024 06:46

graphite-app bot merged commit 1e3499c into canary Jan 30, 2024
32 checks passed

graphite-app bot deleted the eyhn/new-page-infra branch January 30, 2024 06:46

saranshisatgit pushed a commit to Meta-Root-Zones/AFFiNE that referenced this pull request Jan 30, 2024

feat(infra): page infra (toeverything#5618)

fc0e60b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(infra): page infra #5618

feat(infra): page infra #5618

EYHN commented Jan 17, 2024

graphite-app bot commented Jan 17, 2024

EYHN commented Jan 17, 2024 •

edited

codecov bot commented Jan 17, 2024 •

edited

graphite-app bot commented Jan 30, 2024 •

edited

feat(infra): page infra #5618

feat(infra): page infra #5618

Conversation

EYHN commented Jan 17, 2024

graphite-app bot commented Jan 17, 2024

Your org has enabled the Graphite merge queue for merging into canary

EYHN commented Jan 17, 2024 • edited

codecov bot commented Jan 17, 2024 • edited

Codecov Report

graphite-app bot commented Jan 30, 2024 • edited

Merge activity

EYHN commented Jan 17, 2024 •

edited

codecov bot commented Jan 17, 2024 •

edited

graphite-app bot commented Jan 30, 2024 •

edited