Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra): di container #5497

Merged
merged 1 commit into from
Jan 30, 2024
Merged

feat(infra): di container #5497

merged 1 commit into from
Jan 30, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Jan 2, 2024

Copy link

graphite-app bot commented Jan 2, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@EYHN EYHN marked this pull request as draft January 2, 2024 12:34
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (c9f8e49) 64.59% compared to head (48eb6c5) 64.69%.

Files Patch % Lines
packages/common/infra/src/utils/stable-hash.ts 38.46% 13 Missing and 3 partials ⚠️
packages/common/infra/src/di/core/collection.ts 82.27% 8 Missing and 6 partials ⚠️
packages/common/infra/src/di/core/provider.ts 78.78% 10 Missing and 4 partials ⚠️
packages/common/infra/src/di/react/index.ts 11.11% 8 Missing ⚠️
packages/common/infra/src/di/core/identifier.ts 77.77% 1 Missing and 1 partial ⚠️
packages/common/infra/src/di/core/error.ts 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5497      +/-   ##
==========================================
+ Coverage   64.59%   64.69%   +0.09%     
==========================================
  Files         298      306       +8     
  Lines       18423    18632     +209     
  Branches     1489     1542      +53     
==========================================
+ Hits        11901    12054     +153     
- Misses       6352     6392      +40     
- Partials      170      186      +16     
Flag Coverage Δ
server-test 70.91% <ø> (-0.01%) ⬇️
unittest 44.21% <73.68%> (+1.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brooooooklyn Brooooooklyn changed the base branch from eyhn/feat/docs to canary January 2, 2024 12:58
@github-actions github-actions bot added docs Improvements or additions to documentation app:core labels Jan 4, 2024
@EYHN EYHN force-pushed the eyhn/di branch 2 times, most recently from 515db25 to 0b8dd56 Compare January 10, 2024 10:55
@EYHN EYHN changed the base branch from canary to eyhn/move/page-list-core January 10, 2024 10:55
@EYHN EYHN changed the base branch from eyhn/move/page-list-core to canary January 10, 2024 11:18
@EYHN EYHN changed the base branch from canary to eyhn/livedata January 10, 2024 11:25
Copy link

graphite-app bot commented Jan 30, 2024

Merge activity

@EYHN EYHN changed the base branch from eyhn/livedata to canary January 30, 2024 06:42
@graphite-app graphite-app bot merged commit 48eb6c5 into canary Jan 30, 2024
32 checks passed
@graphite-app graphite-app bot deleted the eyhn/di branch January 30, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app docs Improvements or additions to documentation mod:component mod:infra Environment related issues and discussions mod:store mod:workspace Related to workspace mod:workspace-impl test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants